From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18654 invoked by alias); 18 Oct 2002 06:33:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18641 invoked from network); 18 Oct 2002 06:33:33 -0000 Received: from unknown (63.119.183.65) by sources.redhat.com with QMTP; 18 Oct 2002 06:33:33 -0000 Received: (qmail 18136 invoked from network); 17 Oct 2002 21:28:41 -0000 Received: from unknown (HELO doc.com) (24.221.209.215) by external1 with SMTP; 17 Oct 2002 21:28:41 -0000 Message-ID: <3DAF2C71.6030908@doc.com> Date: Thu, 17 Oct 2002 23:33:00 -0000 From: Adam Fedor Organization: Digital Optics Corp. User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US; rv:1.0.0) Gecko/20020610 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jim Blandy CC: Klee Dienes , Michael Snyder , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Redefine skip_quoted References: <95706CBA-DFBC-11D6-A1B6-00039396EEB8@apple.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-10/txt/msg00298.txt.bz2 Jim Blandy wrote: > Klee Dienes writes: > >>In the Apple code, we use skip_quoted to allow for the possibility of >>spaces in Objective-C function names. >> >>I'm actually coming to think that allowing people to break on unquoted >>Objective-C methods was a mistake: it's caused us no end of trouble >>trying to shoehorn decode_line_1() into handling every possible >>edge-case. I'm not sure how practical it is for us to remove it at >>this point, though --- we'd have to do some research among our >>Objective-C developers to find out how important a feature it is to >>them, I think. > > > So, the original patch posted is preparation for a behavior which you > now suspect was a mistake, and which has caused you no end of trouble? > (Or do I have the sense of what you were saying reversed?) You can > forgive me if hearing that makes me a bit hesitant to approve the > patch, right? :) > Well, really the use of skip_quoted for ObjC (in a patch that I haven't submitted yet), really has more to do with handling the canonical form of an Objective-C method symbol (e.g. -[MyObject myMethod:arg2:]) that comes from objc-lang.c. Most of the breakpoint cases that a user would enter are handled elsewhere (in a patch that I also haven't submitted). I'd have to look more closely at how the canonical form is generated (really, demangled) to see if the gdb machinery could handle having quotes around the symbol. I don't know if that would cause other problems. -- Adam Fedor, Digital Optics Corp. | I'm glad I hate spinach, because http://www.doc.com | if I didn't, I'd eat it, and you | know how I hate the stuff.