From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6855 invoked by alias); 16 Oct 2002 19:16:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6844 invoked from network); 16 Oct 2002 19:15:58 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 16 Oct 2002 19:15:58 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g9GItHw12844 for ; Wed, 16 Oct 2002 14:55:17 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9GJFkl15914; Wed, 16 Oct 2002 15:15:46 -0400 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g9GJFjD11856; Wed, 16 Oct 2002 12:15:45 -0700 Message-ID: <3DADBAE1.9C816519@redhat.com> Date: Wed, 16 Oct 2002 12:16:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Adam Fedor CC: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Objective-C language support. References: <3D889A97.90202@doc.com> <3DA375D7.45B9DE9E@redhat.com> <3DAB7E8E.1020002@doc.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-10/txt/msg00283.txt.bz2 Adam Fedor wrote: > > Michael Snyder wrote: > > Adam, this is approved, but do you think you could make > > the comment a little more informative? And Capitolize "Also" > > and add a period. > > > > > > > >> * breakpoint.c (parse_breakpoint_sals): Ignore ObjC method > >> names when checking default. > > This is my minor improvement. Ok? Yes, approved. > > 2002-10-14 Adam Fedor > > * breakpoint.c (parse_breakpoint_sals): Ignore ObjC method > names when matching breakpoints in current file. > > -- > Adam Fedor, Digital Optics Corp. | I'm glad I hate spinach, because > http://www.doc.com | if I didn't, I'd eat it, and you > | know how I hate the stuff. > > ------------------------------------------------------------------------------- > Index: breakpoint.c > =================================================================== > RCS file: /cvs/src/src/gdb/breakpoint.c,v > retrieving revision 1.90 > diff -u -p -r1.90 breakpoint.c > --- breakpoint.c 22 Sep 2002 20:29:52 -0000 1.90 > +++ breakpoint.c 15 Oct 2002 02:31:48 -0000 > @@ -4618,13 +4618,16 @@ parse_breakpoint_sals (char **address, > /* Force almost all breakpoints to be in terms of the > current_source_symtab (which is decode_line_1's default). This > should produce the results we want almost all of the time while > - leaving default_breakpoint_* alone. */ > + leaving default_breakpoint_* alone. > + ObjC: However, don't match an Objective-C method name which > + may have a '+' or '-' succeeded by a '[' */ > > struct symtab_and_line cursal = get_current_source_symtab_and_line (); > > if (default_breakpoint_valid > && (!cursal.symtab > - || (strchr ("+-", (*address)[0]) != NULL))) > + || ((strchr ("+-", (*address)[0]) != NULL) > + && ((*address)[1] != '[')))) > *sals = decode_line_1 (address, 1, default_breakpoint_symtab, > default_breakpoint_line, addr_string); > else