From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20966 invoked by alias); 15 Oct 2002 02:33:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20942 invoked from network); 15 Oct 2002 02:33:48 -0000 Received: from unknown (63.119.183.65) by sources.redhat.com with QMTP; 15 Oct 2002 02:33:48 -0000 Received: (qmail 4473 invoked from network); 15 Oct 2002 01:33:58 -0000 Received: from cpe-24-221-209-215.co.sprintbbd.net (HELO doc.com) (24.221.209.215) by external1 with SMTP; 15 Oct 2002 01:33:58 -0000 Message-ID: <3DAB7E8E.1020002@doc.com> Date: Mon, 14 Oct 2002 19:33:00 -0000 From: Adam Fedor Organization: Digital Optics Corp. User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US; rv:1.0.0) Gecko/20020610 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Michael Snyder CC: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Objective-C language support. References: <3D889A97.90202@doc.com> <3DA375D7.45B9DE9E@redhat.com> Content-Type: multipart/mixed; boundary="------------040803080109070709000405" X-SW-Source: 2002-10/txt/msg00269.txt.bz2 This is a multi-part message in MIME format. --------------040803080109070709000405 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 689 Michael Snyder wrote: > Adam, this is approved, but do you think you could make > the comment a little more informative? And Capitolize "Also" > and add a period. > > > >> * breakpoint.c (parse_breakpoint_sals): Ignore ObjC method >> names when checking default. This is my minor improvement. Ok? 2002-10-14 Adam Fedor * breakpoint.c (parse_breakpoint_sals): Ignore ObjC method names when matching breakpoints in current file. -- Adam Fedor, Digital Optics Corp. | I'm glad I hate spinach, because http://www.doc.com | if I didn't, I'd eat it, and you | know how I hate the stuff. --------------040803080109070709000405 Content-Type: text/plain; name="objc4.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="objc4.patch" Content-length: 1184 Index: breakpoint.c =================================================================== RCS file: /cvs/src/src/gdb/breakpoint.c,v retrieving revision 1.90 diff -u -p -r1.90 breakpoint.c --- breakpoint.c 22 Sep 2002 20:29:52 -0000 1.90 +++ breakpoint.c 15 Oct 2002 02:31:48 -0000 @@ -4618,13 +4618,16 @@ parse_breakpoint_sals (char **address, /* Force almost all breakpoints to be in terms of the current_source_symtab (which is decode_line_1's default). This should produce the results we want almost all of the time while - leaving default_breakpoint_* alone. */ + leaving default_breakpoint_* alone. + ObjC: However, don't match an Objective-C method name which + may have a '+' or '-' succeeded by a '[' */ struct symtab_and_line cursal = get_current_source_symtab_and_line (); if (default_breakpoint_valid && (!cursal.symtab - || (strchr ("+-", (*address)[0]) != NULL))) + || ((strchr ("+-", (*address)[0]) != NULL) + && ((*address)[1] != '[')))) *sals = decode_line_1 (address, 1, default_breakpoint_symtab, default_breakpoint_line, addr_string); else --------------040803080109070709000405--