From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17518 invoked by alias); 9 Oct 2002 00:34:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17511 invoked from network); 9 Oct 2002 00:34:06 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 9 Oct 2002 00:34:06 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g990EPX26298 for ; Tue, 8 Oct 2002 20:14:25 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g990Y4l01860; Tue, 8 Oct 2002 20:34:04 -0400 Received: from redhat.com (dhcp-172-16-25-149.sfbay.redhat.com [172.16.25.149]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g990XxN31031; Tue, 8 Oct 2002 17:33:59 -0700 Message-ID: <3DA37931.3B4DD57C@redhat.com> Date: Tue, 08 Oct 2002 17:34:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Adam Fedor CC: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Objective-C language support. References: <3D889A97.90202@doc.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-10/txt/msg00201.txt.bz2 Adam Fedor wrote: > > This patch adds Objective-C language support to gdb based upon a patch > provided by Apple Computer Inc from their version of gdb. Note that the > patch only contains changes to existing files. New files (objc-lang.h, > objc-lang.c, objc-exp.y) and a gdb.objc testsuite directory are located at > > ftp://ftp.gnustep.org/pub/gnustep/contrib/gdb-objc-patch.tar.gz Adam, Being just a comment, this change can go in immediately. > * source.c (print_source_lines): Update comments. > Index: gdb/source.c > =================================================================== > RCS file: /cvs/src/src/gdb/source.c,v > retrieving revision 1.29 > diff -u -p -r1.29 source.c > --- gdb/source.c 11 Jun 2002 20:36:51 -0000 1.29 > +++ gdb/source.c 17 Sep 2002 19:30:56 -0000 > @@ -1114,8 +1114,9 @@ print_source_lines (struct symtab *s, in > > /* Print a list of files and line numbers which a user may choose from > in order to list a function which was specified ambiguously (as with > - `list classname::overloadedfuncname', for example). The vector in > - SALS provides the filenames and line numbers. */ > + `list classname::overloadedfuncname', or 'list objectiveCSelector:). > + The vector in SALS provides the filenames and line numbers. > + NOTE: some of the SALS may have no filename or line information! */ > > static void > ambiguous_line_spec (struct symtabs_and_lines *sals)