From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9646 invoked by alias); 9 Oct 2002 00:19:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9634 invoked from network); 9 Oct 2002 00:19:46 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 9 Oct 2002 00:19:46 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g99005X22983 for ; Tue, 8 Oct 2002 20:00:05 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g990Jil01769; Tue, 8 Oct 2002 20:19:44 -0400 Received: from redhat.com (dhcp-172-16-25-149.sfbay.redhat.com [172.16.25.149]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g990JgN30556; Tue, 8 Oct 2002 17:19:42 -0700 Message-ID: <3DA375D7.45B9DE9E@redhat.com> Date: Tue, 08 Oct 2002 17:19:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Adam Fedor CC: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Objective-C language support. References: <3D889A97.90202@doc.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-10/txt/msg00199.txt.bz2 Adam Fedor wrote: > > This patch adds Objective-C language support to gdb based upon a patch > provided by Apple Computer Inc from their version of gdb. Note that the > patch only contains changes to existing files. New files (objc-lang.h, > objc-lang.c, objc-exp.y) and a gdb.objc testsuite directory are located at > > ftp://ftp.gnustep.org/pub/gnustep/contrib/gdb-objc-patch.tar.gz Adam, this is approved, but do you think you could make the comment a little more informative? And Capitolize "Also" and add a period. > * breakpoint.c (parse_breakpoint_sals): Ignore ObjC method > names when checking default. > > Index: gdb/breakpoint.c > =================================================================== > RCS file: /cvs/src/src/gdb/breakpoint.c,v > retrieving revision 1.86 > diff -u -p -r1.86 breakpoint.c > --- gdb/breakpoint.c 5 Sep 2002 01:28:14 -0000 1.86 > +++ gdb/breakpoint.c 17 Sep 2002 19:29:52 -0000 > @@ -4618,9 +4618,11 @@ parse_breakpoint_sals (char **address, > current_source_symtab (which is decode_line_1's default). This > should produce the results we want almost all of the time while > leaving default_breakpoint_* alone. */ > + /* also ignore objc method name */ > if (default_breakpoint_valid > && (!current_source_symtab > - || (strchr ("+-", (*address)[0]) != NULL))) > + || ((strchr ("+-", (*address)[0]) != NULL) > + && ((*address)[1] != '[')))) > *sals = decode_line_1 (address, 1, default_breakpoint_symtab, > default_breakpoint_line, addr_string); > else