From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8979 invoked by alias); 9 Oct 2002 00:16:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8971 invoked from network); 9 Oct 2002 00:16:36 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 9 Oct 2002 00:16:36 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g98NutX22351 for ; Tue, 8 Oct 2002 19:56:55 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g990GTl01762; Tue, 8 Oct 2002 20:16:29 -0400 Received: from redhat.com (dhcp-172-16-25-149.sfbay.redhat.com [172.16.25.149]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g990GTN30482; Tue, 8 Oct 2002 17:16:29 -0700 Message-ID: <3DA37517.9BB65A0C@redhat.com> Date: Tue, 08 Oct 2002 17:16:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Adam Fedor CC: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Objective-C language support. References: <3D889A97.90202@doc.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-10/txt/msg00198.txt.bz2 Adam Fedor wrote: > > This patch adds Objective-C language support to gdb based upon a patch > provided by Apple Computer Inc from their version of gdb. Note that the > patch only contains changes to existing files. New files (objc-lang.h, > objc-lang.c, objc-exp.y) and a gdb.objc testsuite directory are located at > > ftp://ftp.gnustep.org/pub/gnustep/contrib/gdb-objc-patch.tar.gz > Approved as obvious: please check it in after the defs.h change goes in. > * language.c (binop_result_type): Add language_objc to case. > (integral_type): Likewise. > (character_type): Likewise. > (string_type): Likewise. > (boolean_type): Likewise. > (structured_type): Likewise. > (binop_type_check): Likewise. > Index: gdb/language.c > =================================================================== > RCS file: /cvs/src/src/gdb/language.c,v > retrieving revision 1.26 > diff -u -p -r1.26 language.c > --- gdb/language.c 1 Aug 2002 17:18:32 -0000 1.26 > +++ gdb/language.c 17 Sep 2002 19:30:31 -0000 > @@ -549,6 +549,7 @@ binop_result_type (struct value *v1, str > { > case language_c: > case language_cplus: > + case language_objc: > if (TYPE_CODE (t1) == TYPE_CODE_FLT) > return TYPE_CODE (t2) == TYPE_CODE_FLT && l2 > l1 ? > VALUE_TYPE (v2) : VALUE_TYPE (v1); > @@ -786,6 +787,7 @@ integral_type (struct type *type) > { > case language_c: > case language_cplus: > + case language_objc: > return (TYPE_CODE (type) != TYPE_CODE_INT) && > (TYPE_CODE (type) != TYPE_CODE_ENUM) ? 0 : 1; > case language_m2: > @@ -828,6 +830,7 @@ character_type (struct type *type) > > case language_c: > case language_cplus: > + case language_objc: > return (TYPE_CODE (type) == TYPE_CODE_INT) && > TYPE_LENGTH (type) == sizeof (char) > ? 1 : 0; > @@ -850,6 +853,7 @@ string_type (struct type *type) > > case language_c: > case language_cplus: > + case language_objc: > /* C does not have distinct string type. */ > return (0); > default: > @@ -868,6 +872,7 @@ boolean_type (struct type *type) > { > case language_c: > case language_cplus: > + case language_objc: > /* Might be more cleanly handled by having a > TYPE_CODE_INT_NOT_BOOL for (OBSOLETE) CHILL and such > languages, or a TYPE_CODE_INT_OR_BOOL for C. */ > @@ -904,6 +909,7 @@ structured_type (struct type *type) > { > case language_c: > case language_cplus: > + case language_objc: > return (TYPE_CODE (type) == TYPE_CODE_STRUCT) || > (TYPE_CODE (type) == TYPE_CODE_UNION) || > (TYPE_CODE (type) == TYPE_CODE_ARRAY); > @@ -1124,6 +1130,7 @@ binop_type_check (struct value *arg1, st > #ifdef _LANG_c > case language_c: > case language_cplus: > + case language_objc: > switch (op) > { > case BINOP_DIV: