From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-19316-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 9638 invoked by alias); 8 Oct 2002 23:24:29 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 9631 invoked from network); 8 Oct 2002 23:24:28 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 8 Oct 2002 23:24:28 -0000
Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g98N4mX09219
	for <gdb-patches@sources.redhat.com>; Tue, 8 Oct 2002 19:04:48 -0400
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g98NOQl01341;
	Tue, 8 Oct 2002 19:24:26 -0400
Received: from redhat.com (dhcp-172-16-25-149.sfbay.redhat.com [172.16.25.149])
	by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g98NOLN28680;
	Tue, 8 Oct 2002 16:24:21 -0700
Message-ID: <3DA368DF.7E55DD4B@redhat.com>
Date: Tue, 08 Oct 2002 16:24:00 -0000
From: Michael Snyder <msnyder@redhat.com>
Organization: Red Hat, Inc.
X-Accept-Language: en
MIME-Version: 1.0
To: Kevin Buettner <kevinb@redhat.com>
CC: Adam Fedor <fedor@doc.com>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] ARI fixes fro objc-lang.[ch]
References: <3D9BAE8E.7000804@doc.com> <1021003235018.ZM30016@localhost.localdomain>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-10/txt/msg00188.txt.bz2

Kevin Buettner wrote:
> 
> On Oct 2,  8:42pm, Adam Fedor wrote:
> 
> > 2002-10-02  Adam Fedor  <fedor@gnu.org>
> >
> >          * objc-lang.c: ARI fixes. Change string.h to gdb_string.h
> >          (objc_demangle): Remove assignment in if statements, free->xfree
> >          (add_msglist): Likewise.
> >          (end_msglist): Likewise.
> >          (complare_selectors): Likewise.
> >          (selectors_info): Likewise.
> >          (compare_classes): Likewise.
> >          (classes_info): Likewise.
> >          (print_object_command): Likewise.
> >          (find_objc_msgcall_submethod): PTR->void *
> >          * objc-lang.h: Remove check for __STDC__
> 
> The patch looks good to me.  I think it's okay to check it in.
> 
> Regarding the format of your ChangeLog entries though...
> 
>   1) Check your ChangeLog entry indentation.  It looks to me like
>      you're indenting by nine spaces.  (A single tab is usually
>      used, though there are a few entries scattered about which
>      use eight spaces instead.)
>   2) Make sure that each sentence ends with a period.
>   3) If a period does not end the line, make sure that there are
>      two spaces between it and the next non-blank character.
>   4) [Now I'm really picking at nits...] I'd rather see:
> 
>         (find_objc_msgcall_submethod): Replace ``PTR'' with ``void *''.
> 
>      instead of:
> 
>         (find_objc_msgcall_submethod): PTR->void *.

Ditto what Kevin said.  Otherwise second his approval.