Keith Seitz wrote:
> 
> Hi,
> 
> Although I know that varobj shouldn't longjmp in case of errors, I don't
> think that this is going to be a safe assumption. I would recommend that
> you refrain from using ui_out_*_begin and ui_out_*_end, and instead use
> make_cleanup_ui_out_*_begin_end and do_cleanups, which will make sure that
> the UIOUT builder is properly reset in case of errors. (See, for example,
> the cleanup that I did in mi_cmd_data_list_registers.)
> 
> On Fri, 27 Sep 2002, J. Johnston wrote:
> 
> > @@ -419,10 +419,10 @@
> >    if ((*name == '*') && (*(name + 1) == '\0'))
> >      {
> >        nv = varobj_list (&rootlist);
> > -      ui_out_tuple_begin (uiout, "changelist");
> > +      ui_out_list_begin (uiout, "changelist");
> >        if (nv <= 0)
> >       {
> > -       ui_out_tuple_end (uiout);
> > +       ui_out_list_end (uiout);
> >         return MI_CMD_DONE;
> >       }
> >        cr = rootlist;
> 
> [Andrew has already addressed the MI0 thing...]
> 
> Other than that, I would recommend that it be approved (for whatever
> that's worth).
> 
> Keith

Thanks Keith.  I have attached the new patch here and have split up the
ChangeLog properly.  I have also taken into account mi0 and mi1 behavior
remaining unchanged.

mi/ChangeLog:

2002-10-02  Jeff Johnston  <jjohnstn@redhat.com>
        
        * mi-cmd-var.c (mi_cmd_var_update): Fix for PR gdb/672.  For m2, output
        list begin and end for "changelist" rather than tuple begin/end.
        (varobj_update_one): For m2, add tuple begin and end for varobj update output.


testsuite/gdb.mi/ChangeLog:

2002-10-02  Jeff Johnston  <jjohnstn@redhat.com>

        * mi-var-block.exp: Change expected output from -var-update
        command to expect list format for "changelist".  Fix for
	PR gdb/672.
        * mi-var-cmd.exp: Ditto.
        * mi-var-child: Ditto.

-- Jeff J.