From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1831 invoked by alias); 1 Oct 2002 19:32:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1824 invoked from network); 1 Oct 2002 19:32:53 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 1 Oct 2002 19:32:53 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g91JE7i31723 for ; Tue, 1 Oct 2002 15:14:07 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g91JWil01480; Tue, 1 Oct 2002 15:32:45 -0400 Received: from redhat.com (dhcp-172-16-25-149.sfbay.redhat.com [172.16.25.149]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g91JWiw31922; Tue, 1 Oct 2002 12:32:44 -0700 Message-ID: <3D99F827.B5579C75@redhat.com> Date: Tue, 01 Oct 2002 12:32:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: David Carlton CC: gdb-patches@sources.redhat.com Subject: Re: [rfa] more all-target -Werror patches References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-10/txt/msg00012.txt.bz2 David Carlton wrote: > > Here are the last patches for getting GDB to build on my machine on > all targets with -Werror if appropriate. > > OK to commit? The gdb_string ones are pretty obvious; I'm not sure > why GCC is issuing a warning on remote-sds.c that requires me to > insert a stray semicolon to quell it, but doing so shouldn't hurt > anything. I'm uneasy about inserting semi-random stuff just to quiet a compiler complaint that doesn't necessarily make sense (is the compiler wrong?) Certainly it should be documented if you do it, else someone later may take it out, not knowing what it's there for. > > David Carlton > carlton@math.stanford.edu > > 2002-09-30 David Carlton > > * Makefile.in (ppc-sysv-tdep.o): Depend on gdb_string_h. > * ppc-sysv-tdep.c: #include "gdb_string.h". > * remote-sds.c (getmessage): Add semicolon after 'retry' label to > pacify GCC. > > Index: Makefile.in > =================================================================== > RCS file: /cvs/src/src/gdb/Makefile.in,v > retrieving revision 1.262.2.7 > diff -u -p -r1.262.2.7 Makefile.in > --- Makefile.in 27 Sep 2002 20:03:04 -0000 1.262.2.7 > +++ Makefile.in 30 Sep 2002 18:47:59 -0000 > @@ -1978,7 +1978,7 @@ ppc-linux-tdep.o: ppc-linux-tdep.c $(def > $(symtab_h) $(target_h) $(gdbcore_h) $(gdbcmd_h) $(symfile_h) \ > $(objfiles_h) $(regcache_h) $(value_h) $(solib_svr4_h) $(ppc_tdep_h) > ppc-sysv-tdep.o: ppc-sysv-tdep.c $(defs_h) $(gdbcore_h) $(inferior_h) \ > - $(regcache_h) $(value_h) $(ppc_tdep_h) > + $(regcache_h) $(value_h) $(gdb_string_h) $(ppc_tdep_h) > ppcbug-rom.o: ppcbug-rom.c $(defs_h) $(gdbcore_h) $(target_h) $(monitor_h) \ > $(serial_h) $(regcache_h) > ppcnbsd-nat.o: ppcnbsd-nat.c $(defs_h) $(inferior_h) $(ppc_tdep_h) \ > > Index: ppc-sysv-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/ppc-sysv-tdep.c,v > retrieving revision 1.1 > diff -u -p -r1.1 ppc-sysv-tdep.c > --- ppc-sysv-tdep.c 30 May 2002 01:21:51 -0000 1.1 > +++ ppc-sysv-tdep.c 30 Sep 2002 18:48:17 -0000 > @@ -25,6 +25,7 @@ > #include "inferior.h" > #include "regcache.h" > #include "value.h" > +#include "gdb_string.h" > > #include "ppc-tdep.h" > > Index: remote-sds.c > =================================================================== > RCS file: /cvs/src/src/gdb/remote-sds.c,v > retrieving revision 1.20 > diff -u -p -r1.20 remote-sds.c > --- remote-sds.c 10 Feb 2002 04:08:42 -0000 1.20 > +++ remote-sds.c 30 Sep 2002 18:45:17 -0000 > @@ -978,6 +978,7 @@ getmessage (unsigned char *buf, int fore > /* Try the whole thing again. */ > retry: > /* need to do something here */ > + ; > } > > /* We have tried hard enough, and just can't receive the packet. Give up. */