Re: [rfa] more all-target -Werror patches

Daniel Jacobowitz
2002-10-01T19:37:07Z

On Tue, Oct 01, 2002 at 12:31:51PM -0700, Michael Snyder wrote:
> David Carlton wrote:
> >
> > Here are the last patches for getting GDB to build on my machine on
> > all targets with -Werror if appropriate.
> >
> > OK to commit? The gdb_string ones are pretty obvious; I'm not sure
> > why GCC is issuing a warning on remote-sds.c that requires me to
> > insert a stray semicolon to quell it, but doing so shouldn't hurt
> > anything.
>
> I'm uneasy about inserting semi-random stuff just to quiet a compiler
> complaint that doesn't necessarily make sense (is the compiler wrong?)
> Certainly it should be documented if you do it, else someone later may
> take it out, not knowing what it's there for.

Well, it's right. Labels without any expression to label aren't legal
C.

--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer