Re: [rfa] more all-target -Werror patches

David Carlton
2002-10-01T20:15:09Z

On 01 Oct 2002 12:43:42 -0700, David Carlton <carlton@math.Stanford.EDU> said:

> How about I change the existing comment

> /* need to do something here */

> to

> /* FIXME: We need to do something here. For now, just put in a
> semicolon so the label has an expression to stick to. (GCC will
> complain otherwise.) */

> And yes, I realize that FIXME's should ideally have a name attached to
> them, but that name should be the author of the original comment
> rather than mine, and I don't know who that is.

Now that I look at the code, I'm really not sure what comment should
go there. It's not clear to me what the intent of the original
comment is: I'd assumed that it meant that there should be code after
the retry label, but it's not at all clear to me why one would expect
that to be the case: the function looks sensible enough as it is.
So maybe I should leave the initial comment intact, and add the
following comment:

/* NOTE: carlton/2002-10-01: The semicolon is there so the label has
an expression to stick to. (GCC will complain otherwise.) */