Re: [rfa] more all-target -Werror patches

David Carlton
2002-10-01T19:43:47Z

On Tue, 1 Oct 2002 15:37:12 -0400, Daniel Jacobowitz <drow@mvista.com> said:
> On Tue, Oct 01, 2002 at 12:31:51PM -0700, Michael Snyder wrote:

>> I'm uneasy about inserting semi-random stuff just to quiet a
>> compiler complaint that doesn't necessarily make sense (is the
>> compiler wrong?) Certainly it should be documented if you do it,
>> else someone later may take it out, not knowing what it's there
>> for.

> Well, it's right. Labels without any expression to label aren't
> legal C.

I'm glad to know it's right; on the other hand, I agree with Michael
that it should be documented. How about I change the existing comment

/* need to do something here */

to

/* FIXME: We need to do something here. For now, just put in a
semicolon so the label has an expression to stick to. (GCC will
complain otherwise.) */

And yes, I realize that FIXME's should ideally have a name attached to
them, but that name should be the author of the original comment
rather than mine, and I don't know who that is.