From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-19002-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 15402 invoked by alias); 27 Sep 2002 19:27:23 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 15392 invoked from network); 27 Sep 2002 19:27:21 -0000
Received: from unknown (HELO localhost.redhat.com) (216.138.202.10)
  by sources.redhat.com with SMTP; 27 Sep 2002 19:27:21 -0000
Received: from redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 548523E77; Fri, 27 Sep 2002 15:27:21 -0400 (EDT)
Message-ID: <3D94B119.9000306@redhat.com>
Date: Fri, 27 Sep 2002 12:27:00 -0000
From: Andrew Cagney <ac131313@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: David Carlton <carlton@math.stanford.edu>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa] missing #include "gdb_string.h"
References: <ro1y99nl00j.fsf@jackfruit.Stanford.EDU>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-09/txt/msg00676.txt.bz2

> I did an all targets build, and it's turned up some missing #include
> "gdb_string.h" locations.
> 
> The patch is below; it's obvious, but I'm doing an RFA because I'm not
> actually running on the target machines in question and because I'm
> paranoid.

It's ok.

> For what it's worth, the targets powerpc-eabi and v850-elf fail when
> build with -Werror for other reasons; I haven't looked into them yet,
> and I have no reason to believe that they can't be fixed in a
> similarly trivial manner.

Which compiler/host?
Andrew


> David Carlton
> carlton@math.stanford.edu
> 
> 2002-09-26  David Carlton  <carlton@math.stanford.edu>
> 
> 	* Makefile.in (cris-tdep.o): Depend on gdb_string_h.
> 	(mcore-tdep.o): Ditto.
> 	(ns32k-tdep.o): Ditto.
> 	(ns32knbsd-tdep.o): Ditto.
> 	(sh3-rom.o): Ditto.
> 	(vax-tdep.o): Ditto.
> 	* cris-tdep.c: #include "gdb_string.h"
> 	* mcore-tdep.c: Ditto.
> 	* ns32k-tdep.c: Ditto.
> 	* ns32knbsd-tdep.c: Ditto.
> 	* sh3-rom.c: Ditto.
> 	* vax-tdep.c: Ditto.