From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30606 invoked by alias); 27 Sep 2002 02:15:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30598 invoked from network); 27 Sep 2002 02:15:48 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 27 Sep 2002 02:15:48 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id B286B3E1B; Thu, 26 Sep 2002 22:15:48 -0400 (EDT) Message-ID: <3D93BF54.30809@redhat.com> Date: Thu, 26 Sep 2002 19:15:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Fernando Nasser Cc: gdb-patches@sources.redhat.com Subject: Re: RFC/RFA: Move new disassembler to libgdb proper References: <3D9394BA.2040605@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-09/txt/msg00656.txt.bz2 Two tweeks: > + /* Disassemble support for GDB. > + Copyright 2000, 2001, 2002 Free Software Foundation, Inc. > + Contributed by Cygnus Solutions (a Red Hat company). The (C) should just be 2002 and ``Red Hat, Inc.''. > + This file is part of GDB. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 2 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program; if not, write to the Free Software > + Foundation, Inc., 59 Temple Place - Suite 330, > + Boston, MA 02111-1307, USA. */ > + > + extern void gdb_disassembly (char *file_string, > + int line_num, > + int mixed_source_and_assembly, > + int how_many, CORE_ADDR low, CORE_ADDR high); It needs #ifdef DISASM_H et.al. It should take an explicit ui_out parameter. As for the rest vis: > ! static int > ! gdb_dis_asm_read_memory (bfd_vma memaddr, bfd_byte * myaddr, > ! unsigned int len, disassemble_info * info) > ! { > ! extern struct target_ops exec_ops; I guess we all get to grit our teeth because we know you're just moving around existing code :-) Andrew