From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15538 invoked by alias); 25 Sep 2002 19:18:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15488 invoked from network); 25 Sep 2002 19:17:59 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 25 Sep 2002 19:17:59 -0000 Received: from redhat.com (totem.toronto.redhat.com [172.16.14.242]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 1D88C8001BC; Wed, 25 Sep 2002 15:17:59 -0400 (EDT) Message-ID: <3D920BE7.8050409@redhat.com> Date: Wed, 25 Sep 2002 12:18:00 -0000 From: Fernando Nasser Organization: Red Hat , Inc. - Toronto User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1) Gecko/20020827 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/resubmit] shlib-call.exp: stepping out... References: <1020730190942.ZM16441@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-09/txt/msg00622.txt.bz2 Kevin Buettner wrote: > This is a resubmission of > > http://sources.redhat.com/ml/gdb-patches/2002-07/msg00566.html > > The current patch (below) is identical to the previous patch with the > exception that the "obvious" portion has been committed (and therefore > no longer shows up in the patch). > > Here's what I said about this patch in my previous post: > > Anyway, regarding the "step out of shr2" test changes, the IRIX > compiler doesn't emit line number information for the epilogue, so we > don't see the step onto the final ``}'' of the function. I don't > see a problem with this behavior. I've revised the test to accept > either behavior. > > I've also revised the messages a little bit to account for the > restructuring of the test. > > Okay to commit? > Yes, go ahead. But please send context diffs next time. Fernando > * gdb.base/shlib-call.exp (step inside shr2): Don't fail if first > step ends up stepping out of the function instead of stopping on > the epilogue. > > Index: testsuite/gdb.base/shlib-call.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/shlib-call.exp,v > retrieving revision 1.6 > diff -u -p -r1.6 shlib-call.exp > --- testsuite/gdb.base/shlib-call.exp 30 Jul 2002 18:51:23 -0000 1.6 > +++ testsuite/gdb.base/shlib-call.exp 30 Jul 2002 18:56:55 -0000 > @@ -239,18 +239,27 @@ gdb_expect { > > #step -return > send_gdb "step\n" > + # A step at this point will either take us entirely out of > + # the function or into the function's epilogue. The exact > + # behavior will differ depending upon upon whether or not > + # the compiler emits line number information for the epilogue. > gdb_expect { > - -re ".*\\\}.*$gdb_prompt $" { pass "step inside shr2 (shlib func)"} > - -re ".*$gdb_prompt $" { fail "step inside shr2 (shlib func)" } > - timeout { fail "step inside shr2 (shlib func) (timeout)" } > - } > - > - send_gdb "step\n" > - gdb_expect { > - -re "main \\(\\) at.*g = mainshr1\\(g\\);.*$gdb_prompt $" { pass "step out of shr2 to main"} > - -re ".*$gdb_prompt $" { fail "step out of shr2 to main" } > + -re "main \\(\\) at.*g = mainshr1\\(g\\);.*$gdb_prompt $" { > + pass "step out of shr2 to main" > + } > + -re ".*\\\}.*$gdb_prompt $" { > + pass "step out of shr2 to main (stopped in shr2 epilogue)" > + send_gdb "step\n" > + gdb_expect { > + -re "main \\(\\) at.*g = mainshr1\\(g\\);.*$gdb_prompt $" { pass "step out of shr2 epilogue to main"} > + -re ".*$gdb_prompt $" { fail "step out of shr2 epilogue to main" } > + timeout { fail "step out of shr2 epilogue to main (timeout)" } > + } > + } > + -re ".*$gdb_prompt $" { fail "step out of shr2" } > timeout { fail "step out of shr2 to main (timeout)" } > } > + > > #print mainshr1(1) > send_gdb "print mainshr1(1)\n" > -- Fernando Nasser Red Hat - Toronto E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9