From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7096 invoked by alias); 19 Sep 2002 03:46:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7088 invoked from network); 19 Sep 2002 03:46:04 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 19 Sep 2002 03:46:04 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id F34173DB4; Wed, 18 Sep 2002 23:45:58 -0400 (EDT) Message-ID: <3D894876.9040706@ges.redhat.com> Date: Wed, 18 Sep 2002 20:46:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Michael Snyder Cc: gdb-patches@sources.redhat.com, klee@apple.com, jingham@apple.com Subject: Re: [PATCH] Part 2 of Objective-C support References: <3D892AAC.5FC93773@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-09/txt/msg00451.txt.bz2 Michael, I'm reverting this change. It modifies a lot of files, many of which are maintained by people other than you and I don't think it falls into the ``obvious'' category. Can you please break these changes down into obvious (eg language_objc enum in defs.h) and not so obvious so people can at least get a change to digest this. Andrew > 2002-09-18 Michael Snyder > > Preliminary support for Objective-C: > * defs.h (language_objc): New enum value. > (puts_filtered_tabular): Declaration only, exported from utils.c. > (skip_quoted): Delete, declared in completer.h. > * c-exp.y: Include completer.h. > * p-exp.y: Ditto. > * jv-exp.y: Ditto. > * expression.h (OP_MSGCALL, OP_SELECTOR, OP_SELF, OP_NSSTRING): > New operator enum values. > * language.h (CAST_IS_CONVERSION): Test for language_objc. > * language.c (binop_result_type): Handle language_objc case. > (integral_type, character_type, string_type, boolean_type, > structured_type, binop_type_check): Ditto. > * symtab.h (SYMBOL_OBJC_DEMANGLED_NAME): Define. > (struct objc_specific): Add to general_symbol_info. > (SYMBOL_INIT_LANGUAGE_SPECIFIC): Add objc initialization. > (SYMBOL_DEMANGLED_NAME): Handle objc case. > * parser-defs.h (struct objc_class_str): New struct type. > (start_msglist, end_msglist, add_msglist): Declaration only, > exported from objc-lang.c. > * value.h (value_of_local, value_nsstring, > call_function_by_hand_expecting_type): Exported from valops.c. > * valops.c (find_function_addr): Export. > (call_function_by_hand_expecting_type): New function. > (value_of_local): New function. > * symfile.c (init_filename_language_table): Add ".m" extension > for Objective-C. > * utils.c (puts_filtered_tabular): New function. > (fprintf_symbol_filtered): Add objc demangling support (disabled). > (set/show demangle): Extend help-string to refer to ObjC. > * elfread.c (elf_symtab_read): Skip Objective-C special symbols. > * stabsread.c (symbol_reference_defined): Objective-C symbols > may contain colons: make allowances when scanning stabs strings > for colons. > (objc_find_colon): New function. > * printcmd.c (address_info): If language == objc then print > "self" instead of "this". > * parse.c (length_of_subexp): Handle new operators OP_MSGCALL, > OP_NSSTRING, and OP_SELF. > (prefixify_subexp): Ditto. > * source.c (print_source_lines): Mention objc in comment. > * breakpoint.c (parse_breakpoint_sals): Recognize Objective-C > method names. >