From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8408 invoked by alias); 18 Sep 2002 19:04:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8401 invoked from network); 18 Sep 2002 19:04:09 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 18 Sep 2002 19:04:09 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id LAA24870; Wed, 18 Sep 2002 11:51:32 -0700 (PDT) Message-ID: <3D88CE27.F264DB19@redhat.com> Date: Wed, 18 Sep 2002 12:04:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Andrew Cagney CC: Adam Fedor , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Objective-C language support. References: <3D889A97.90202@doc.com> <3D88BCD1.5379F383@redhat.com> <3D88CC99.8010803@ges.redhat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-09/txt/msg00416.txt.bz2 Andrew Cagney wrote: > > > Adam Fedor wrote: > > > >> > >> This patch adds Objective-C language support to gdb based upon a patch > >> provided by Apple Computer Inc from their version of gdb. Note that the > >> patch only contains changes to existing files. New files (objc-lang.h, > >> objc-lang.c, objc-exp.y) and a gdb.objc testsuite directory are located at > >> > >> ftp://ftp.gnustep.org/pub/gnustep/contrib/gdb-objc-patch.tar.gz > >> > > > > > > > > Oh lord. I suppose I am the only one here who is > > even noddingly familiar with Objective C? > > > > There's a good chance that I wrote some of this code > > anyway, so I'll try to have a look at it. You know, > > of course, that we can't just drop something this huge > > into the source tree without some review... > > > > I'll need the ability to run the tests. Does GCC already > > have enough objc to compile them? Will I need any special > > libraries? > > For Ada, a different approach has been taken: > > - commit the new files (but not changes to old files) > - commit the makefile rules for the new files (but not changes that > would cause these files to build by default) > - clean the files up so that they meet current coding conventions - > -Werror, ARI, ... (for Ada the files were all K&R, looking back.) > - slowly contribute/merge the patches to other files > - add the missing makefile bits making it part of GDB > > This way, the bulk of the code is in the mainline. I think it works > better since: > > - people can see the code (there have already been several patches go > through where the Ada code was ``fixed'' for free, just by virtue of > being part of the repository). > - while being developed, doesn't break the existing builds > > With this, the worst that can happen is the code never gets enabled. > > The other thing is that, very like when someone adds new a architecture, > other than the contributor, no one immediatly cares if it doesn't work > quite right. Just as long as it hasn't actually broken other parts of > GDB and hasn't hasn't done anything really really nasty at the > implementation level (ari and -Werror cover most of that). > > enjoy, > Andrew Thanks, I'll try this approach. On that principal, I will check in the objc-specific files right away. I do wish I had some names for their actual authors, though... Michael