From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21197 invoked by alias); 17 Sep 2002 16:29:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21148 invoked from network); 17 Sep 2002 16:29:47 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 17 Sep 2002 16:29:47 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 7A8373DAA; Tue, 17 Sep 2002 12:29:47 -0400 (EDT) Message-ID: <3D87587B.9080304@ges.redhat.com> Date: Tue, 17 Sep 2002 09:29:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: David Carlton Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] convert blocks to dictionaries, phase 1, main part References: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-09/txt/msg00342.txt.bz2 David, Some brief stylistic notes (ref http://sources.redhat.com/gdb/current/onlinedocs/gdbint_13.html#SEC113) - create a header ``dictionary.h'' / ``nametab.h'' / ... that defines the interfaces for this new object. - macro's are bad m'kay :-) - the function names should be lower case - just implement interfaces sufficient for the immediate needs. For instance, instead of providing ``enum dict_type'', just describe the idea. Since we can compile with -Werror, changing internal interface, when there is evidence that it is actually needed, has become relativly easy. - keep gdbint.texinfo in mind - you'll want to start compiling all targets enjoy, Andrew