From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30189 invoked by alias); 27 Aug 2002 23:37:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30181 invoked from network); 27 Aug 2002 23:37:39 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 27 Aug 2002 23:37:39 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id E4E4E3C40; Tue, 27 Aug 2002 19:37:38 -0400 (EDT) Message-ID: <3D6C0D42.8030401@ges.redhat.com> Date: Tue, 27 Aug 2002 16:53:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: tromey@redhat.com Cc: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: RFA: osabi.c correctness patch (Was: new build failure) References: <87n0r8i35t.fsf@fleche.redhat.com> <15723.52602.741154.488098@localhost.redhat.com> <87d6s4hwwy.fsf_-_@fleche.redhat.com> <877kichw4e.fsf@fleche.redhat.com> <15723.64906.189232.478903@localhost.redhat.com> <878z2sgcdn.fsf@fleche.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00927.txt.bz2 >>>>>> "Elena" == Elena Zannoni writes: > > > Elena> I wonder if we should enable ,-Werror by default on certain > Elena> platforms. > > I was under the impression that the maintainers used it regularly. > That's why I enabled it in my builds -- to avoid submitting > embarrassing patches in the future :-) BTW, your warnings had me puzzled. I'm building on 7.3, and wasn't seeing these! It turns out that I wasn't using the pre-installed compiler :-( Anyway, yes, maintainers should have -Werror enabled. Unfortunatly, the best laid plans can occasionally fall down during the implementation stage. enjoy, Andrew