From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27325 invoked by alias); 27 Aug 2002 22:14:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27318 invoked from network); 27 Aug 2002 22:14:57 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 27 Aug 2002 22:14:57 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 43E2A3C40; Tue, 27 Aug 2002 18:14:57 -0400 (EDT) Message-ID: <3D6BF9E1.4010005@ges.redhat.com> Date: Tue, 27 Aug 2002 15:16:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Keith Seitz Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] add selected-frame-level-changed events References: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00917.txt.bz2 > On Tue, 27 Aug 2002, Andrew Cagney wrote: > > >> Why not put it in there anyway? > > > You mean add a notification in select_frame? Because UIs don't care when > GDB is temporarily switching frames for whatever reason. What matters is > when something happens to cause the current frame to be changed and cause > gdb and the MI client to get out of sync. As far as I know, this only > happens via the command line frame commands (up, down, frame). There might > be others, but I've never seen them. Wonder what the TUI gets up to :-) >> I think, not putting it in select_frame() is the part that needs the fixme. > > > Right, that's what I meant. Sorry if I was vague. Ideally, we would like > it in select_frame, but we cannot do that right now because the UI would > be informed of billions of frame changes per step, especially if varobj is > operating. Ok. Can you just add comments explaining the above, especially in select_frame(), so that people know why the call isn't yet there. As for the unnecessary select frame calls, I guess ``we'' are working on it. I suspect that varobj could do with an audit --- use FRAME_ID() and frame parameterized versions of various functions. Andrew