From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7216 invoked by alias); 23 Aug 2002 22:45:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7209 invoked from network); 23 Aug 2002 22:45:25 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 23 Aug 2002 22:45:25 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id PAA24391; Fri, 23 Aug 2002 15:39:17 -0700 (PDT) Message-ID: <3D66BB04.31240DA8@redhat.com> Date: Fri, 23 Aug 2002 16:15:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Minor reformatting in infrun.c References: <20020817001848.GX906@gnat.com> <3D5DB58E.3A856EB3@redhat.com> <20020822234116.GU25997@gnat.com> <3D657A41.EBE52A4B@redhat.com> <20020823162729.GZ25997@gnat.com> <3D667E8E.8616E88F@redhat.com> <20020823220232.GB25997@gnat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00782.txt.bz2 Joel Brobecker wrote: > > > > I can commit the following patch. I verified that a later re-indent > > > does not cause a formatting change in the second argument. > > > > Yes, > > I committed this change. > > > and now I can see no reason not to put the arguments back > > the way they were originally. Or, say. > > > > stop_bpstat = > > bpstat_stop_status (&stop_pc, > > [...] > > Absolutely. But unfortunately this is not the way indent formats it: > > << > stop_bpstat = > bpstat_stop_status > (&stop_pc, > sw_single_step_trap_p > || (currently_stepping (ecs) > && prev_pc != stop_pc - DECR_PC_AFTER_BREAK > && !(step_range_end > && INNER_THAN (read_sp (), (step_sp - 16))))); > >> > > Should I check-in the indent'ed version anyway? (I would send a separate > [PATCH] message) Nah, I guess we've wasted enough cycles worrying about this rather trivial change. ;-)