From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5563 invoked by alias); 23 Aug 2002 22:42:46 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5553 invoked from network); 23 Aug 2002 22:42:46 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 23 Aug 2002 22:42:46 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id PAA24359; Fri, 23 Aug 2002 15:36:38 -0700 (PDT) Message-ID: <3D66BA65.8073CCD6@redhat.com> Date: Fri, 23 Aug 2002 15:45:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Daniel Jacobowitz CC: gdb-patches@sources.redhat.com Subject: Re: RFA (threads testsuite): More thread tests References: <20020709154033.GA7204@nevyn.them.org> <3D65751B.98E850BA@redhat.com> <20020823013447.GA18835@nevyn.them.org> <3D66843D.99DC8A49@redhat.com> <20020823190254.GA26364@nevyn.them.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00781.txt.bz2 Daniel Jacobowitz wrote: > > On Fri, Aug 23, 2002 at 11:51:41AM -0700, Michael Snyder wrote: > > Daniel Jacobowitz wrote: > > > > > > On Thu, Aug 22, 2002 at 04:34:51PM -0700, Michael Snyder wrote: > > > > Daniel Jacobowitz wrote: > > > > > > > > > > Here's two tests I had lying around from when I developed the gdbserver > > > > > threads support. Gdbserver passes them with flying colors (if you use my > > > > > other patch which lets gdbserver run tests properly). GDB shows a couple of > > > > > problems, unpredictably (not always repeatable). > > > > > > > > > > OK to add these? > > > > > > > > Hi Joel, > > > > > > > > I understand the point of schedlock.exp, but what's the point of > > > > print-threads.exp? What is it that you're testing? > > > > > > No specific feature - just the general ability to handle threads doing > > > things. It has a slightly different behavior pattern than the other > > > threads testscases, and triggered different problems. Oh, and I > > > remember - there is no other testcase in the testsuite with > > > pthread_join in it; no threads ever actually exit. I found some > > > problems there while I was implementing the gdbserver threads support. > > > > OK, then, since we definitely need more thread testing, > > let's accept these. I like the way you verified that > > schedlock was implemented for the target before testing it. > > > > BTW, do these really have to be native-only? They should > > work for embedded pthread targets, shouldn't they? > > (And I'll make them use the new compile command too!) > > Sure. But which ones will it work on, that's the question. I'm > tempted to have a gdb_skip_threads_test, but not sure what to key it > off of... Well -- if they won't build (eg. because there's no threads library), it's a pretty sure bet they won't run. If they do build...