From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12302 invoked by alias); 23 Aug 2002 18:48:23 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12295 invoked from network); 23 Aug 2002 18:48:22 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 23 Aug 2002 18:48:22 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id LAA21740; Fri, 23 Aug 2002 11:42:17 -0700 (PDT) Message-ID: <3D668375.92B9FF9B@redhat.com> Date: Fri, 23 Aug 2002 11:51:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Grace Sainsbury CC: gdb-patches@sources.redhat.com Subject: Re: breakpoint error messages References: <20020821142627.A10117@tomago.toronto.redhat.com> <3D655542.AF3065A0@redhat.com> <20020822173220.A12466@tomago.toronto.redhat.com> <3D656355.E623B495@redhat.com> <20020823115315.A13713@tomago.toronto.redhat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00763.txt.bz2 Grace Sainsbury wrote: > > How about this? > > The memory_error is only relevant for memory > breakpoints, and only insert_breakpoint returns an errno (the hardware > and catcpoint functions return -1 on error)-- so the call to strerror > prints the error when it is relevant, and so replaces print_sys_errmsg. > > grace Much better, thanks. The only concern I still have is about the msg "the same program may be running in another process". Your patch will now print that message much more often than before, both because you eliminated the #ifdef, and because you're going to print it any time -any- error or warning occurs. Even though we all hate ifdefs, I suggest you leave this one in, since taking it out will result in a behavior change, and I suggest you use another boolian variable to determine when it should be printed (set the variable true at the point where the existing code prints the message). Given those changes, you can go ahead and check it in without re-submitting. Thanks, Michael