From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23281 invoked by alias); 22 Aug 2002 23:56:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23274 invoked from network); 22 Aug 2002 23:56:50 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 22 Aug 2002 23:56:50 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id QAA09454; Thu, 22 Aug 2002 16:50:57 -0700 (PDT) Message-ID: <3D657A41.EBE52A4B@redhat.com> Date: Thu, 22 Aug 2002 18:25:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Minor reformatting in infrun.c References: <20020817001848.GX906@gnat.com> <3D5DB58E.3A856EB3@redhat.com> <20020822234116.GU25997@gnat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00741.txt.bz2 Joel Brobecker wrote: > > > I hate long lines as much as anybody, but I hate defeating indent > > even more. The middle part of this is just going to go back to > > the right again, the first time indent gets run. > > > > You might prefer to have it happen under your control... > > Argh! That's right! Thanks. > > After adding the followig dummy comment, the "indent"-ed version stays > very close to the hand-formatted version. Should I check it in? > (note, the attached patch does not include the changes introduced after > running gdb_indent). Err, I was actually meaning to say "let's conform with indent", rather than "let's defeat indent". How about moving the comment outside the argument list? Then the args can stay as they were. > > 2002-08-22 Joel Brobecker > > * infrun.c (handle_inferior_event): Add a dummy comment to > help indent find a more readable formatting of this line of code. > > Thanks, > -- > Joel > > ------------------------------------------------------------------------ > > infrun.c.diffName: infrun.c.diff > Type: Plain Text (text/plain)