From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22583 invoked by alias); 21 Aug 2002 02:08:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22535 invoked from network); 21 Aug 2002 02:08:18 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 21 Aug 2002 02:08:18 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 3D4993DA0; Tue, 20 Aug 2002 22:08:17 -0400 (EDT) Message-ID: <3D62F611.10207@ges.redhat.com> Date: Tue, 20 Aug 2002 19:08:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020810 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Michael Snyder Cc: gdb-patches@sources.redhat.com, cagney@redhat.com, kevinb@redhat.com Subject: Re: [RFA] mips_register_virtual_type References: <200208202355.g7KNtsv00654@reddwarf.sfbay.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00647.txt.bz2 > Andrew, Kevin, > > I think with this change, mips_virtual_register_type is robust enough > to use with all mips configurations. What do you think? Can we > blow away the remaining definitions of REGISTER_VIRTUAL_TYPE? See other e-mail. Andrew > 2002-08-20 Michael Snyder > > * mips-tdep.c (mips_register_virtual_type): Account for > FP_REGISTER_DOUBLE. > > Index: mips-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/mips-tdep.c,v > retrieving revision 1.115 > diff -p -r1.115 mips-tdep.c > *** mips-tdep.c 20 Aug 2002 23:07:42 -0000 1.115 > --- mips-tdep.c 21 Aug 2002 00:10:08 -0000 > *************** if (TARGET_BYTE_ORDER == BFD_ENDIAN_BIG > *** 571,577 **** > definitions found in config/mips/tm-*.h. I'm concerned about > the ``FCRCS_REGNUM <= reg && reg <= LAST_EMBED_REGNUM'' clause > though. In some cases FP_REGNUM is in this range, and I doubt > ! that this code is correct for the 64-bit case. */ > > static struct type * > mips_register_virtual_type (int reg) > --- 571,581 ---- > definitions found in config/mips/tm-*.h. I'm concerned about > the ``FCRCS_REGNUM <= reg && reg <= LAST_EMBED_REGNUM'' clause > though. In some cases FP_REGNUM is in this range, and I doubt > ! that this code is correct for the 64-bit case. > ! > ! MVS: FCRCS_REGNUM will not overlap with the FP registers. > ! On Irix, the FP registers run from 32 to 63 and FCRCS is 69. > ! Everywhere else, they run from 38 to 69 and FCRCS is 70. */ > > static struct type * > mips_register_virtual_type (int reg) > *************** mips_register_virtual_type (int reg) > *** 580,588 **** > { > /* Floating point registers... */ > if (TARGET_BYTE_ORDER == BFD_ENDIAN_BIG) > ! return builtin_type_ieee_double_big; > else > ! return builtin_type_ieee_double_little; > } > else if (reg == PS_REGNUM /* CR */) > return builtin_type_uint32; > --- 584,594 ---- > { > /* Floating point registers... */ > if (TARGET_BYTE_ORDER == BFD_ENDIAN_BIG) > ! return FP_REGISTER_DOUBLE ? > ! builtin_type_ieee_double_big : builtin_type_ieee_single_big; > else > ! return FP_REGISTER_DOUBLE ? > ! builtin_type_ieee_double_little : builtin_type_ieee_single_little; > } > else if (reg == PS_REGNUM /* CR */) > return builtin_type_uint32; >