From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20262 invoked by alias); 21 Aug 2002 01:55:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20250 invoked from network); 21 Aug 2002 01:55:27 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 21 Aug 2002 01:55:27 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 3B3083DA0; Tue, 20 Aug 2002 21:55:26 -0400 (EDT) Message-ID: <3D62F30E.8070007@ges.redhat.com> Date: Tue, 20 Aug 2002 18:55:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020810 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Michael Snyder Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] mips gdbarch-ify REGISTER_NAMES, SKIP_TRAMPOLINE_CODE... References: <200208202229.g7KMTNS00534@reddwarf.sfbay.redhat.com> <3D62DE8C.2030609@ges.redhat.com> <3D62E509.88B51F5A@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00646.txt.bz2 > Andrew Cagney wrote: > >> > >> > Only tm-mips.h seems to define REGISTER_NAME, so this should be safe. >> > >> > 2002-08-20 Michael Snyder >> > >> > * mips-tdep.c (mips_skip_stub, mips_in_call_stub): Make static. >> > (mips_gdbarch_init): Set skip_trampoline_code, >> > in_solib_call_trampoline. >> > * config/mips/tm-mips.h (REGISTER_NAME): Delete. >> > (IN_SOLIB_CALL_TRAMPOLINE, SKIP_TRAMPOLINE_CODE): Delete. > >> >> Just add a comment pointing out that most embedded mips targets don't >> use this, instead they override it using the REGISTER_NAMES macro. > > > OK. > > >> I would also steer well clear of REGISTER_VIRTUAL_TYPE, >> REGISTER_RAW_SIZE and REGISTER_VIRTUAL_SIZE and anything else related to >> register numbers. > > > When you say "steer well clear of", do you mean "don't touch them"? > All but register_virtual_type have already been gdbarch-ified, and > I was building up my courage to do that one (see separate thread). Then please don't change that! Mult-arching the mips properly depends on changes to remote.c and on figuring out exactly what all the include header spagetti in config/mips actually does. It is simply too easy to introduce a change that modifies the layout of the register cache and, as a consequence, break GDB's ability to talk to specific remote targets. Andrew