From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-17894-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 4062 invoked by alias); 21 Aug 2002 01:12:38 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 4055 invoked from network); 21 Aug 2002 01:12:37 -0000
Received: from unknown (HELO cygnus.com) (205.180.83.203)
  by sources.redhat.com with SMTP; 21 Aug 2002 01:12:37 -0000
Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id SAA04718;
	Tue, 20 Aug 2002 18:07:13 -0700 (PDT)
Message-ID: <3D62E509.88B51F5A@redhat.com>
Date: Tue, 20 Aug 2002 18:12:00 -0000
From: Michael Snyder <msnyder@redhat.com>
Organization: Red Hat, Inc.
X-Accept-Language: en
MIME-Version: 1.0
To: Andrew Cagney <ac131313@ges.redhat.com>
CC: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] mips gdbarch-ify REGISTER_NAMES, SKIP_TRAMPOLINE_CODE...
References: <200208202229.g7KMTNS00534@reddwarf.sfbay.redhat.com> <3D62DE8C.2030609@ges.redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-08/txt/msg00644.txt.bz2

Andrew Cagney wrote:
> 
> > Only tm-mips.h seems to define REGISTER_NAME, so this should be safe.
> >
> > 2002-08-20  Michael Snyder  <msnyder@redhat.com>
> >
> >       * mips-tdep.c (mips_skip_stub, mips_in_call_stub): Make static.
> >       (mips_gdbarch_init): Set skip_trampoline_code,
> >       in_solib_call_trampoline.
> >       * config/mips/tm-mips.h (REGISTER_NAME): Delete.
> >       (IN_SOLIB_CALL_TRAMPOLINE, SKIP_TRAMPOLINE_CODE): Delete.
> 
> Just add a comment pointing out that most embedded mips targets don't
> use this, instead they override it using the REGISTER_NAMES macro.

OK.

> I would also steer well clear of REGISTER_VIRTUAL_TYPE,
> REGISTER_RAW_SIZE and REGISTER_VIRTUAL_SIZE and anything else related to
> register numbers.

When you say "steer well clear of", do you mean "don't touch them"?
All but register_virtual_type have already been gdbarch-ified, and
I was building up my courage to do that one (see separate thread).