Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@ges.redhat.com>
To: Michael Snyder <msnyder@cygnus.com>
Cc: gdb-patches@sources.redhat.com, cagney@redhat.com
Subject: Re: [PATCH] mips gdbarch-ify REGISTER_NAMES, SKIP_TRAMPOLINE_CODE...
Date: Tue, 20 Aug 2002 17:27:00 -0000	[thread overview]
Message-ID: <3D62DE8C.2030609@ges.redhat.com> (raw)
In-Reply-To: <200208202229.g7KMTNS00534@reddwarf.sfbay.redhat.com>

> Only tm-mips.h seems to define REGISTER_NAME, so this should be safe.
> 
> 2002-08-20  Michael Snyder  <msnyder@redhat.com>
> 
> 	* mips-tdep.c (mips_skip_stub, mips_in_call_stub): Make static.
> 	(mips_gdbarch_init): Set skip_trampoline_code, 
> 	in_solib_call_trampoline.
> 	* config/mips/tm-mips.h (REGISTER_NAME): Delete.
> 	(IN_SOLIB_CALL_TRAMPOLINE, SKIP_TRAMPOLINE_CODE): Delete.

Just add a comment pointing out that most embedded mips targets don't 
use this, instead they override it using the REGISTER_NAMES macro.

I would also steer well clear of REGISTER_VIRTUAL_TYPE, 
REGISTER_RAW_SIZE and REGISTER_VIRTUAL_SIZE and anything else related to 
register numbers.

Andrew



  reply	other threads:[~2002-08-21  0:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-20 15:46 Michael Snyder
2002-08-20 17:27 ` Andrew Cagney [this message]
2002-08-20 18:12   ` Michael Snyder
2002-08-20 18:55     ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D62DE8C.2030609@ges.redhat.com \
    --to=ac131313@ges.redhat.com \
    --cc=cagney@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=msnyder@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox