From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12828 invoked by alias); 18 Aug 2002 20:35:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12821 invoked from network); 18 Aug 2002 20:35:38 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 18 Aug 2002 20:35:38 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 150C13CFA; Sun, 18 Aug 2002 16:35:28 -0400 (EDT) Message-ID: <3D60050F.3020508@ges.redhat.com> Date: Sun, 18 Aug 2002 13:35:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020810 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Mark Kettenis , gdb-patches@sources.redhat.com Subject: [PATCH] regcache raw read/write partial; Was: [PATCH] Remove some write_register_bytes occurences from i386-tdep.c References: <200208181718.g7IHIrg6029437@elgar.kettenis.dyndns.org> <3D5FDD69.7000102@ges.redhat.com> <3D5FFEA6.9000306@ges.redhat.com> <200208182019.g7IKJGLp000325@elgar.kettenis.dyndns.org> Content-Type: multipart/mixed; boundary="------------070407040706070407020108" X-SW-Source: 2002-08/txt/msg00526.txt.bz2 This is a multi-part message in MIME format. --------------070407040706070407020108 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 762 > Date: Sun, 18 Aug 2002 16:08:06 -0400 > From: Andrew Cagney > > > As for write_register_bytes() can it be avoided? I've just posted ``regcache_cooked_write_with_offset_hack(). But I don't think that hack is right here. Perhaphs a single register read - modify - write function is needed? > > Hmm, > > I just hit a need for the same operation while implementing some pseudo > registers. Just adding: > > regcache_raw_read_part(regcache,regnum,offset,length,buf) > regcache_raw_write_part(regcache,regnum,offset,length,buf) > > Where OFFSET would be the byte offset into the register I suppose. > > Seems like a good idea to me. Yes, something like the attached. I'll commit in a few hours, Andrew --------------070407040706070407020108 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 2813 2002-08-18 Andrew Cagney * regcache.c (regcache_raw_xfer_part): New function. * regcache.h (regcache_raw_read_part): Declare. (regcache_raw_write_part): Declare. Index: regcache.c =================================================================== RCS file: /cvs/src/src/gdb/regcache.c,v retrieving revision 1.53 diff -u -r1.53 regcache.c --- regcache.c 13 Aug 2002 23:06:40 -0000 1.53 +++ regcache.c 18 Aug 2002 20:27:18 -0000 @@ -916,6 +916,46 @@ } } +/* Perform a partial register transfer using a read, modify, write + operation. */ + +void +regcache_raw_xfer_part (struct regcache *regcache, int regnum, + int offset, int len, void *in, const void *out) +{ + struct regcache_descr *descr = regcache->descr; + bfd_byte *reg = alloca (descr->max_register_size); + gdb_assert (regnum >= 0 && regnum < descr->nr_raw_registers); + gdb_assert (offset >= 0 && offset < descr->sizeof_register[regnum]); + gdb_assert (len >= 0 && len + offset < descr->sizeof_register[regnum]); + /* Read (when needed) ... */ + if (in != NULL + || offset > 0 + || offset + len < descr->sizeof_register[regnum]) + regcache_raw_read (regcache, regnum, reg); + /* ... modify ... */ + if (in != NULL) + memcpy (in, reg + offset, len); + if (out != NULL) + memcpy (reg + offset, out, len); + /* ... write (when needed). */ + if (out != NULL) + regcache_raw_write (regcache, regnum, reg); +} + +void +regcache_raw_read_part (struct regcache *regcache, int regnum, + int offset, int len, void *buf) +{ + regcache_raw_xfer_part (regcache, regnum, offset, len, buf, NULL); +} + +void +regcache_raw_write_part (struct regcache *regcache, int regnum, + int offset, int len, const void *buf) +{ + regcache_raw_xfer_part (regcache, regnum, offset, len, NULL, buf); +} /* Return the contents of register REGNUM as an unsigned integer. */ Index: regcache.h =================================================================== RCS file: /cvs/src/src/gdb/regcache.h,v retrieving revision 1.14 diff -u -r1.14 regcache.h --- regcache.h 13 Aug 2002 14:32:28 -0000 1.14 +++ regcache.h 18 Aug 2002 20:27:18 -0000 @@ -44,6 +44,13 @@ int regnum, ULONGEST *val); int regcache_valid_p (struct regcache *regcache, int regnum); +/* Raw partial transfers. These perform read, modify, write style + operations. */ +void regcache_raw_read_part (struct regcache *regcache, int regnum, + int offset, int len, void *buf); +void regcache_raw_write_part (struct regcache *regcache, int regnum, + int offset, int len, const void *buf); + /* Transfer a cooked register [0..NUM_REGS+NUM_PSEUDO_REGS). */ void regcache_cooked_read (struct regcache *regcache, int rawnum, void *buf); void regcache_cooked_write (struct regcache *regcache, int rawnum, --------------070407040706070407020108--