From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28191 invoked by alias); 16 Aug 2002 19:00:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28184 invoked from network); 16 Aug 2002 19:00:58 -0000 Received: from unknown (HELO tetsuo.nj.caldera.com) (63.124.204.226) by sources.redhat.com with SMTP; 16 Aug 2002 19:00:58 -0000 Received: from caldera.com (localhost.localdomain [127.0.0.1]) by tetsuo.nj.caldera.com (8.11.6/8.11.6) with ESMTP id g7GJDDC13233; Fri, 16 Aug 2002 15:13:14 -0400 Message-ID: <3D5D4EC9.C3D5630A@caldera.com> Date: Fri, 16 Aug 2002 12:00:00 -0000 From: Petr Sorfa Organization: Caldera X-Accept-Language: en MIME-Version: 1.0 To: Jim Blandy CC: "gdb-patches@sources.redhat.com" Subject: Re: [RFA] DWARF multiple comp unit header support - Revision - Part 1 References: <3D2F0E4F.DDCC4DE9@caldera.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00441.txt.bz2 Hi Jim, > Petr Sorfa writes: > > 2002-07-12 Petr Sorfa (petrs@caldera.com) > > > > * dwarf2read.c (ABBREV_HASH_SIZE): moved definition > > forward in the code to be defined before > > struct comp_unit_head. > > (comp_unit_head): Added several new members, > > some are being used with this patch, some not. > > offset - Offset of the cu_header in .debug_info > > begin_offset - Base offset of cu_header into program > > next - Next comp unit head in program > > dwarf2_abbrevs - abbreviation tables associated with > > comp unit header. > > The members must be documented in the code, and thus need only be > named in the ChangeLog entry. Ok. I just like putting some additional info into the change log so folks can see what is going in. I'll pull it out. > > *************** struct comp_unit_head > > *** 174,179 **** > > --- 179,194 ---- > > unsigned int offset_size; /* size of file offsets; either 4 or 8 */ > > unsigned int initial_length_size; /* size of the length field; either > > 4 or 12 */ > > + > > + /* New information for the comp unit head so as to keep a list > > + of available ones for a program. */ > > + unsigned int offset; /* Offset of the cu_header in .debug_info */ > > + char *base_offset; /* Base offset after cu_header into program */ > > + char *begin_offset; /* Base offset of cu_header into program */ > > + struct comp_unit_head *next; /* Next comp unit head in program */ > > + > > + struct abbrev_info *dwarf2_abbrevs[ABBREV_HASH_SIZE]; /* DWARF abbrev > > + table */ > > }; > > > > /* The line number information for a compilation unit (found in the > > These comments need to be much more expansive. It's very important > that data structures be clearly explained. How is "Base offset > *after* cu_header into program" different from "Base offset *of* > cu_header into program"? Yes, will do. > Have you compared test suite results with and without this patch? I did and as far as I remember this resulted in the same results. I need to retest on TOT. Thanks for the comments. Petr