From: Andrew Cagney <ac131313@ges.redhat.com>
To: Michael Snyder <msnyder@redhat.com>
Cc: gdb-patches@sources.redhat.com, cagney@redhat.com
Subject: Re: [PATCH] mips gdbarch-ification
Date: Thu, 15 Aug 2002 18:42:00 -0000 [thread overview]
Message-ID: <3D5C5866.2070607@ges.redhat.com> (raw)
In-Reply-To: <3D5C50C5.A666EDF9@redhat.com>
Michael,
The below should not be part of this change, be sure to not commit it.
(but thanks for cleaning up those methods)
Andrew
> *************** mips_frame_chain (struct frame_info *fra
> *** 2294,2302 ****
> we loop forever if we see a zero size frame. */
> if (PROC_FRAME_REG (proc_desc) == SP_REGNUM
> && PROC_FRAME_OFFSET (proc_desc) == 0
> ! /* The previous frame from a sigtramp frame might be frameless
> ! and have frame size zero. */
> ! && !frame->signal_handler_caller)
> return 0;
> else
> return get_frame_pointer (frame, proc_desc);
> --- 2302,2312 ----
> we loop forever if we see a zero size frame. */
> if (PROC_FRAME_REG (proc_desc) == SP_REGNUM
> && PROC_FRAME_OFFSET (proc_desc) == 0
> ! /* The previous frame from a sigtramp frame might be frameless
> ! and have frame size zero. */
> ! && !frame->signal_handler_caller
> ! /* Check if this is a call dummy frame. */
> ! && frame->pc != mips_call_dummy_address ())
> return 0;
> else
> return get_frame_pointer (frame, proc_desc);
> *************** mips_o32o64_push_arguments (int nargs,
> *** 2959,2965 ****
> argreg = A0_REGNUM;
> float_argreg = FPA0_REGNUM;
>
> ! /* the struct_return pointer occupies the first parameter-passing reg */
> if (struct_return)
> {
> if (mips_debug)
> --- 2969,2975 ----
> argreg = A0_REGNUM;
> float_argreg = FPA0_REGNUM;
>
> ! /* The struct_return pointer occupies the first parameter-passing reg. */
> if (struct_return)
> {
> if (mips_debug)
> *************** mips_pop_frame (void)
> *** 3346,3358 ****
> if (frame->saved_regs == NULL)
> FRAME_INIT_SAVED_REGS (frame);
> for (regnum = 0; regnum < NUM_REGS; regnum++)
> ! {
> ! if (regnum != SP_REGNUM && regnum != PC_REGNUM
> ! && frame->saved_regs[regnum])
> ! write_register (regnum,
> ! read_memory_integer (frame->saved_regs[regnum],
> ! MIPS_SAVED_REGSIZE));
> ! }
> write_register (SP_REGNUM, new_sp);
> flush_cached_frames ();
>
> --- 3356,3377 ----
> if (frame->saved_regs == NULL)
> FRAME_INIT_SAVED_REGS (frame);
> for (regnum = 0; regnum < NUM_REGS; regnum++)
> ! if (regnum != SP_REGNUM && regnum != PC_REGNUM
> ! && frame->saved_regs[regnum])
> ! {
> ! /* Floating point registers must not be sign extended,
> ! in case MIPS_SAVED_REGSIZE = 4 but sizeof (FP0_REGNUM) == 8. */
> !
> ! if (FP0_REGNUM <= regnum && regnum < FP0_REGNUM + 32)
> ! write_register (regnum,
> ! read_memory_unsigned_integer (frame->saved_regs[regnum],
> ! MIPS_SAVED_REGSIZE));
> ! else
> ! write_register (regnum,
> ! read_memory_integer (frame->saved_regs[regnum],
> ! MIPS_SAVED_REGSIZE));
> ! }
> !
> write_register (SP_REGNUM, new_sp);
> flush_cached_frames ();
>
> *************** return_value_location (struct type *valt
> *** 4079,4093 ****
> if (TARGET_BYTE_ORDER == BFD_ENDIAN_BIG
> && len < MIPS_SAVED_REGSIZE)
> {
> ! /* "un-left-justify" the value in the low register */
> ! lo->reg_offset = MIPS_SAVED_REGSIZE - len;
> ! lo->len = len;
> hi->reg_offset = 0;
> hi->len = 0;
> }
> else if (TARGET_BYTE_ORDER == BFD_ENDIAN_BIG
> && len > MIPS_SAVED_REGSIZE /* odd-size structs */
> && len < MIPS_SAVED_REGSIZE * 2
> && (TYPE_CODE (valtype) == TYPE_CODE_STRUCT ||
> TYPE_CODE (valtype) == TYPE_CODE_UNION))
> {
> --- 4098,4125 ----
> if (TARGET_BYTE_ORDER == BFD_ENDIAN_BIG
> && len < MIPS_SAVED_REGSIZE)
> {
> ! if ((gdbarch_tdep (current_gdbarch) -> mips_abi == MIPS_ABI_N32
> ! || gdbarch_tdep (current_gdbarch) -> mips_abi == MIPS_ABI_N64)
> ! && (TYPE_CODE (valtype) == TYPE_CODE_STRUCT
> ! || TYPE_CODE (valtype) == TYPE_CODE_UNION))
> ! {
> ! /* Values are already aligned in the low register. */
> ! lo->reg_offset = 0;
> ! }
> ! else
> ! {
> ! /* "un-left-justify" the value in the low register */
> ! lo->reg_offset = MIPS_SAVED_REGSIZE - len;
> ! }
> hi->reg_offset = 0;
> + lo->len = len;
> hi->len = 0;
> }
> else if (TARGET_BYTE_ORDER == BFD_ENDIAN_BIG
> && len > MIPS_SAVED_REGSIZE /* odd-size structs */
> && len < MIPS_SAVED_REGSIZE * 2
> + && gdbarch_tdep (current_gdbarch) -> mips_abi != MIPS_ABI_N32
> + && gdbarch_tdep (current_gdbarch) -> mips_abi != MIPS_ABI_N64
> && (TYPE_CODE (valtype) == TYPE_CODE_STRUCT ||
> TYPE_CODE (valtype) == TYPE_CODE_UNION))
> {
next prev parent reply other threads:[~2002-08-16 1:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-15 18:26 Michael Snyder
2002-08-15 18:42 ` Andrew Cagney [this message]
2002-08-15 20:11 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D5C5866.2070607@ges.redhat.com \
--to=ac131313@ges.redhat.com \
--cc=cagney@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox