From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14021 invoked by alias); 14 Aug 2002 22:47:14 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13987 invoked from network); 14 Aug 2002 22:47:13 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 14 Aug 2002 22:47:13 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id PAA22040; Wed, 14 Aug 2002 15:43:18 -0700 (PDT) Message-ID: <3D5AD966.83B6ADB@redhat.com> Date: Wed, 14 Aug 2002 15:47:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Neil Booth CC: gdb-patches@sources.redhat.com Subject: Re: [TESTSUITE] assert (char == signed char) References: <3D5AC6F4.8D119BF4@redhat.com> <20020814220650.GB12340@daikokuya.co.uk> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00356.txt.bz2 Neil Booth wrote: > > Michael Snyder wrote:- > > > There seem to be some tests in the testsuite that are > > based on the assumption that chars are signed, and that > > will fail if they are unsigned. > > > > Eg: > > sizeof.exp: check valueof ((int) (char)) -1 == -1 > > (prints 255 if char == unsigned) > > > > pointers.exp: ptype pC > > (outputs "unsigned char *" if char == unsigned) > > > > Any thoughts? Should these be regularized to accept unsigned? > > Should it be based on a configure variable? > > I'd pass -fsigned-char; that's done in some other tests. To gcc? Problem is, what if it isn't gcc? As eg. Irix cc?