From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13197 invoked by alias); 14 Aug 2002 19:23:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13190 invoked from network); 14 Aug 2002 19:23:47 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 14 Aug 2002 19:23:47 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id MAA18543; Wed, 14 Aug 2002 12:19:58 -0700 (PDT) Message-ID: <3D5AA9BC.3580169B@redhat.com> Date: Wed, 14 Aug 2002 12:23:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Andrew Cagney CC: gdb-patches@sources.redhat.com Subject: Re: [RFA] Mips, return_value_location, small structs References: <3D5438A9.5F0FA8A8@redhat.com> <3D545AB2.4030803@ges.redhat.com> <3D545BC7.B41142D4@redhat.com> <3D547CE2.6070403@ges.redhat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00351.txt.bz2 Andrew Cagney wrote: > > > Andrew Cagney wrote: > > > >> > > > >> > Re-submitted as a separate patch. > >> > > >> > The problem: small structs returned in one (or two) registers > >> > are aligned left in N32/N64 and aligned right in the others > >> > (or vice versa, depending on how you cross your eyes). > > > >> > >> I _think_ you also need to add o32. Can you check that out? Just post > >> the results, not the patch. > > > > > > I know o32 needs work too, but the two can be treated separately. > > I do guarantee that this patch does not make o32 any worse. > > In fact, I have been testing to make sure that none of my patches > > have made o32 any worse. > > > > Can I check this one in for n32, if I promise to work on o32 next? > > Why not just fix this bug for all three ABIs? o32 is just like n32/n64 > in that it cross-eyes the arguments. Andrew, o32 works as it is. I can't find anything related to this patch that still needs to be done for o32. Unles you can suggest something specific, may I check this patch in? Michael