From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9503 invoked by alias); 14 Aug 2002 00:21:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9492 invoked from network); 14 Aug 2002 00:21:05 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 14 Aug 2002 00:21:05 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 34E413D39; Tue, 13 Aug 2002 20:21:04 -0400 (EDT) Message-ID: <3D59A270.2050409@ges.redhat.com> Date: Tue, 13 Aug 2002 17:21:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020810 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com, msnyder@redhat.com Subject: Re: [RFA] procfs.c: TARGET_CAN_USE_HARDWARE_WATCHPOINT via target vector References: <1020812213802.ZM1237@localhost.localdomain> <3D5975FF.3080106@ges.redhat.com> <1020813213928.ZM6904@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00337.txt.bz2 > On Aug 13, 5:11pm, Andrew Cagney wrote: > > >> > +#ifndef TARGET_HAS_HARDWARE_WATCHPOINTS > >> >> I just think the macro should be `largely' renamed: >> ``PROCFS_HAS_HARDWARE_WATCHPOINTS''. >> >> Largely? There are a few exceptions -- i386v-nat.c and mips/tm-embed.h >> which could be left alone. > > > For the procfs related uses, I suspect that we can eliminate the use > of the macro altogether. (I'd prefer to get Michael's opinion though > before attempting such a change.) That would be even better! I'm just trying to ensure that someone doesn't try to sneak in a reference to ..._HAS_HARDWARE_WATCHPOINTS where they shouldn't (ie. outside of procfs.c :-). enjoy, Andrew