From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-17574-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 24407 invoked by alias); 13 Aug 2002 21:55:37 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 24400 invoked from network); 13 Aug 2002 21:55:35 -0000
Received: from unknown (HELO localhost.redhat.com) (216.138.202.10)
  by sources.redhat.com with SMTP; 13 Aug 2002 21:55:35 -0000
Received: from ges.redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 102593D39; Tue, 13 Aug 2002 17:55:34 -0400 (EDT)
Message-ID: <3D598055.1000308@ges.redhat.com>
Date: Tue, 13 Aug 2002 14:55:00 -0000
From: Andrew Cagney <ac131313@ges.redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020810
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Mark Kettenis <kettenis@chello.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa:i386] Add mmx registers
References: <3D55A89F.9040300@ges.redhat.com> <867kiwkky6.fsf@elgar.kettenis.dyndns.org> <3D5805BF.2050409@ges.redhat.com> <3D591939.1020706@ges.redhat.com> <200208132139.g7DLdDnd026621@elgar.kettenis.dyndns.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-08/txt/msg00324.txt.bz2

>    Date: Tue, 13 Aug 2002 10:35:37 -0400
>    From: Andrew Cagney <ac131313@ges.redhat.com>
> 
>    > Hello,
>    > 
>    > This adds mmx registers to the i386.
>    > 
> 
>    Done, this is what I committed.
> 
> Ouch!  This patch uncovers a problem in the new regcache code and
> segfaults on my FreeBSD 4.6-STABLE system.  The problem is that:

My Red Hat GNU/Linux tests didn't bat an eyelid :-(

>    +  set_gdbarch_pseudo_register_read (gdbarch, i386_pseudo_register_read);
>    +  set_gdbarch_pseudo_register_write (gdbarch, i386_pseudo_register_write);
> 
> changes the i386 target's register cache from "legacy" to "new".  This
> means that there isn't room for the pseudo registers in
> register_valid_p, yet registers_changed() tries to frob the entries
> for the pseudo registers.
> 
> I don't see an obvious way to fix this.  Any bright ideas Andrew?

Hmm, yes.  It should be clearing:
	[0 .. current_regcache->descr->nr_raw_registers)

Andrew