> Andrew Cagney <ac131313@ges.redhat.com> writes:
> 
> 
> Hello,
> 
> This adds mmx registers to the i386.
> 
> 
> Great, a few nits though :-(
> 
> * Please rename is_mmx_regnum() to mmx_regnum_p().
> 
> * Please rename nr_mmx_regs to mmx_num_regs.
> 
> * Why do you use regcache_raw_read_as_address() in
>   mmx_regnum_to_fp_regnum?  Looks misleading to me...
> 
> (because I happen to know what the function does :-)
> I'll rename the function to ..._as_longest().
> 
> I'll fix the others.

Done, this is what I committed.

It also includes raw versions of the ..._unsigned() functions since the 
mmx code needs to access the raw register cache.

Andrew