From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18431 invoked by alias); 12 Aug 2002 18:23:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18419 invoked from network); 12 Aug 2002 18:23:50 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 12 Aug 2002 18:23:50 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 0EB663CFC; Mon, 12 Aug 2002 14:23:49 -0400 (EDT) Message-ID: <3D57FD34.2050809@ges.redhat.com> Date: Mon, 12 Aug 2002 11:23:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020810 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa:i386] Eliminate register_byte() and register_raw_size() References: <3D5477D2.6090403@ges.redhat.com> <3D547D35.6050003@ges.redhat.com> <86adnskm9c.fsf@elgar.kettenis.dyndns.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00269.txt.bz2 > Andrew Cagney writes: > > >> > This patch eliminates the register_byte() and register_raw_size() >> > architecture methods from the i386. >> > >> > (It was either that or modify the code so that it included MMX >> > registers :-) > > > Well, the generic code is probably a wee bit slower... > > ...but we can always add back a more generic version of the "offset caching" code that your patch removes if that turns out to be a problem... Or remove all calls to REGISTER_BYTE() :-) Oh, and the regcache already does ``offset caching'' :-) >> > ok to commit? > > > ...so it's fine with me. Please go ahead. Thanks! Andrew