From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5615 invoked by alias); 11 Aug 2002 15:26:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5568 invoked from network); 11 Aug 2002 15:26:12 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 11 Aug 2002 15:26:12 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 01D683C53; Sun, 11 Aug 2002 11:26:07 -0400 (EDT) Message-ID: <3D56820F.3060702@ges.redhat.com> Date: Sun, 11 Aug 2002 08:26:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020810 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: RFA/remote: Clean up remote_open_1 and friend References: <20020811034227.GA11733@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00246.txt.bz2 > I was looking at some future changes to remote_open_1, and didn't want to > duplicate them in remote_async_open_1, so I folded the two functions > together. The changes were pretty small, and I think reasonable. Andrew, > any thoughts? This will let me kill the wrapper functions in a later patch, > I think. I'm considering adding local state to the target stack right > now... which will make autodetecting which remote protocol to use even > simpler and cleaner. Yes! > + remote_open_1 (name, from_tty, &extended_remote_ops, 1 /*extended_p */, 0); Can you just add a parameter name comment so it reads ``0 /* async_p */''. Andrew