Andrew Cagney wrote: > > > These changes fix 16 testsuite failures, based in the Irix native > > compiler running with -n32 (and produce no regressions for -o32). > > Yes, with tweaks. > > General comment. You may want to consider restructuring the function to > read: > > for (argument in arguments) > for (argument broken down in to 8 byte chunks) > if (fp argument && fnpreg <= num fp arg regs) > write argument chunk to fp register > else if (!fp argument && reg <= num arg regs) > write chunk (carefully aligned) to gp register > else > write chunk to (carefully aligned) memory OK, I've checked in, with all of your tweaks except for the above. Come on, you can't ask me to restructure the whole function just to get what was originally a 5-line change in!!! ;-) As it is, I've fixed a bunch of bugs that weren't mine, just to get this in. Diffs that went in attached below.