From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-17461-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 27682 invoked by alias); 9 Aug 2002 14:46:57 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 27674 invoked from network); 9 Aug 2002 14:46:55 -0000
Received: from unknown (HELO localhost.redhat.com) (216.138.202.10)
  by sources.redhat.com with SMTP; 9 Aug 2002 14:46:55 -0000
Received: from ges.redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP id 148433D2A
	for <gdb-patches@sources.redhat.com>; Fri,  9 Aug 2002 10:46:53 -0400 (EDT)
Message-ID: <3D53D5DC.8010207@ges.redhat.com>
Date: Fri, 09 Aug 2002 07:46:00 -0000
From: Andrew Cagney <ac131313@ges.redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020802
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA]: Change all fopen modes to binary in cli-dump.c [was Re:
 [RFA] cli/cli-dump.c: Write dump always in binary mode on Cygwin]
References: <Pine.SUN.3.91.1020808080458.4988D-100000@is> <3D52A2E9.8070005@ges.redhat.com> <20020809111915.M4229@cygbert.vinschen.de>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-08/txt/msg00211.txt.bz2

> On Thu, Aug 08, 2002 at 12:57:13PM -0400, Andrew Cagney wrote:
> 
>> BTW,
>> 
>> NickC's just pointed Corinna and I at include/fopen-{bin,same}.c.  I 
>> guess GDB could just use those when it wants a binary file open.
> 
> 
> In the light of this I had a closer look to cli/cli-dump.c and
> found that there are a lot of constand "w"'s "a"'s and "r"'s
> used.  So the previous patch was pretty incomplete.  The below
> patch substitutes every constant fopen mode in cli/cli-dump.c
> by the appropriate binary open mode define from include/fopen-bin.h.
> 
> Ok to check in?
> 
> Corinna
> 
> 2002-08-09  Corinna Vinschen  <vinschen@redhat.com>
> 
> 	* cli/cli-dump.c: Change fopen modes to use binary open modes
> 	as defined in include/fopen-bin.h throughout.
> 

Yes, thanks!  (I think I'll try to figure out a way of ARIing this so 
that we don't forget again :-)

Andrew