From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9636 invoked by alias); 6 Aug 2002 23:23:14 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9629 invoked from network); 6 Aug 2002 23:23:13 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 6 Aug 2002 23:23:13 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id QAA26841; Tue, 6 Aug 2002 16:21:20 -0700 (PDT) Message-ID: <3D5055FB.674B2E70@redhat.com> Date: Tue, 06 Aug 2002 16:23:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Andrew Cagney CC: gdb-patches@sources.redhat.com Subject: Re: [RFA] 32/64 mistake in mips_find_saved_regs References: <3D4F54EA.6CA82E5E@redhat.com> <3D5030EA.9060102@ges.redhat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00152.txt.bz2 Andrew Cagney wrote: > > I believe n32 should be setting mips64 to 1. Can you please change that. . Really? So you think mips64 specifies 64-bit registers, rather than 64 bit addresses? I'll try the change, and see what happens. > As for the below, yes ok. Can you please also update the comment to > read something like: > > ``[Apparently] The freg_offset gives the offset to the first 64 bit saved. > > When the ABI specifies 64 bit saved registers, the FREG_OFFSET > designates the first saved 64 bit register. > > When the ABI specifies 32 bit saved registers, the ``64 bit saved > DOUBLE'' consists of two adjacent 32 bit registers, Hence FREG_OFFSET, > designates the address of the lower register of the register pair. > Adjust the offset so that it designates the upper register of the pair > -- i.e., the address of the first saved 32 bit register.'' > > I think that is more correct. Will do. > > Andrew > > > Here is a test that should check for stack/register size, not > > whether target == mips64. > > > > Fixes four failures in callfuncs.exp, no other regressions. > > > > > > > > 2002-08-05 Michael Snyder > > > > * mips-tdep.c (mips_find_saved_regs): Adjust stack according > > to MIPS_SAVED_REGSIZE, not GDB_TARGET_IS_MIPS64. N32 is not > > MIPS64, but it does save 64 bits worth of register. > > > > Index: mips-tdep.c > > =================================================================== > > RCS file: /cvs/src/src/gdb/mips-tdep.c,v > > retrieving revision 1.88 > > diff -p -r1.88 mips-tdep.c > > *** mips-tdep.c 1 Aug 2002 23:10:34 -0000 1.88 > > --- mips-tdep.c 6 Aug 2002 04:32:33 -0000 > > *************** mips_find_saved_regs (struct frame_info > > *** 1371,1379 **** > > were saved. */ > > reg_position = fci->frame + PROC_FREG_OFFSET (proc_desc); > > > > ! /* The freg_offset points to where the first *double* register > > ! is saved. So skip to the high-order word. */ > > ! if (!GDB_TARGET_IS_MIPS64) > > reg_position += MIPS_SAVED_REGSIZE; > > > > /* Fill in the offsets for the float registers which float_mask says > > --- 1371,1379 ---- > > were saved. */ > > reg_position = fci->frame + PROC_FREG_OFFSET (proc_desc); > > > > ! /* The freg_offset points to where the first *double* register is > > ! saved. So skip to the high-order word if saved_reg_size == 4. */ > > ! if (MIPS_SAVED_REGSIZE == 4) > > reg_position += MIPS_SAVED_REGSIZE; > > > > /* Fill in the offsets for the float registers which float_mask says