From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14685 invoked by alias); 6 Aug 2002 21:49:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14678 invoked from network); 6 Aug 2002 21:49:38 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 6 Aug 2002 21:49:38 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id OAA25185; Tue, 6 Aug 2002 14:47:47 -0700 (PDT) Message-ID: <3D50400D.957FADD7@redhat.com> Date: Tue, 06 Aug 2002 14:49:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Andrew Cagney CC: gdb-patches@sources.redhat.com Subject: Re: [RFA] mips-n32 use_struct_convention References: <3D49EB9E.3A59088D@redhat.com> <3D503EF6.9080902@ges.redhat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00141.txt.bz2 Andrew Cagney wrote: > > > *************** show_mask_address (char *cmd, int from_t > > *** 561,570 **** > > int > > mips_use_struct_convention (int gcc_p, struct type *type) > > { > > ! if (MIPS_EABI) > > return (TYPE_LENGTH (type) > 2 * MIPS_SAVED_REGSIZE); > > else > > ! return 1; /* Structures are returned by ref in extra arg0 */ > > } > > > > /* Tell if the program counter value in MEMADDR is in a MIPS16 function. */ > > --- 570,579 ---- > > int > > mips_use_struct_convention (int gcc_p, struct type *type) > > { > > ! if (MIPS_EABI || MIPS_NEWABI) > > return (TYPE_LENGTH (type) > 2 * MIPS_SAVED_REGSIZE); > > else > > ! return 1; /* Old ABI: structures are returned by ref in extra arg0 */ > > } > > > > Rather than doing this, can you please create two functions --- one for > each case --- and then update mips_gdbarch_init() accordingly. OK. Patch withdrawn pending rewrite.