From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23315 invoked by alias); 6 Aug 2002 14:02:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23300 invoked from network); 6 Aug 2002 14:02:52 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 6 Aug 2002 14:02:52 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 66AB53C93; Tue, 6 Aug 2002 10:02:51 -0400 (EDT) Message-ID: <3D4FD70B.6090001@ges.redhat.com> Date: Tue, 06 Aug 2002 07:02:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020802 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Eli Zaretskii Cc: Michael Snyder , gdb-patches@sources.redhat.com Subject: Re: [RFA] cli/cli-dump.c: Write dump always in binary mode on Cygwin References: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00121.txt.bz2 > On Mon, 5 Aug 2002, Michael Snyder wrote: > > >> do we actually know of any environments >> where the #if is strictly necessary? > > > Since GDB requires ISO C, and "wb" is part of the ISO C spec, I think we > can drop the #if. (Dependance on O_BINARY being defined is not very > clean anyway, IMHO, since O_BINARY does not belong to `fopen'.) Just to be pedantic. GDB requires an ISO C syntax compiler but not the ISO C support libraries. However, until there is evidence to the contrary, I agree we should assume it is going to work. Andrew