From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27061 invoked by alias); 6 Aug 2002 04:39:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27054 invoked from network); 6 Aug 2002 04:39:05 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 6 Aug 2002 04:39:05 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id VAA10020; Mon, 5 Aug 2002 21:37:26 -0700 (PDT) Message-ID: <3D4F4E88.9DDFB7BE@redhat.com> Date: Mon, 05 Aug 2002 21:39:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Andrew Cagney CC: gdb-patches@sources.redhat.com Subject: Re: [Fwd: gcore for netbsd] References: <3D4D6C36.8050407@ges.redhat.com> <3D4F023B.A6B5BD9@redhat.com> <3D4F4E3B.4010801@ges.redhat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00117.txt.bz2 Andrew Cagney wrote: > > > Andrew Cagney wrote: > > > >> > >> Hello, > >> > >> This patch has made me wonder why gcore even includes . > > > > > > I'm guessing it went in before I split some code out into linux-proc.c. > > > > > > > >> Can anyone think of a reason for not simply removing the include? > > > > > > Try it and see... > > Going going .... > > >> I'm also wondering what the function preempt_derive_stack_segment() is > >> for. I can't find any callers. > > > > > > Probably for future use -- for systems where the default method didn't > > work, or where there was a more efficient method available. > > It can't be a global though. That is going to be very multi-arch / > multi-target unfriendly. > > Mind if that gets removed as well? As it is, it is wrong. Sure, go ahead.