From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20091 invoked by alias); 6 Aug 2002 04:19:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20071 invoked from network); 6 Aug 2002 04:19:12 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 6 Aug 2002 04:19:12 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id B5CD23D85; Tue, 6 Aug 2002 00:19:07 -0400 (EDT) Message-ID: <3D4F4E3B.4010801@ges.redhat.com> Date: Mon, 05 Aug 2002 21:19:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020802 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Michael Snyder Cc: gdb-patches@sources.redhat.com, cagney@redhat.com Subject: Re: [Fwd: gcore for netbsd] References: <3D4D6C36.8050407@ges.redhat.com> <3D4F023B.A6B5BD9@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00116.txt.bz2 > Andrew Cagney wrote: > >> >> Hello, >> >> This patch has made me wonder why gcore even includes . > > > I'm guessing it went in before I split some code out into linux-proc.c. > > > >> Can anyone think of a reason for not simply removing the include? > > > Try it and see... Going going .... >> I'm also wondering what the function preempt_derive_stack_segment() is >> for. I can't find any callers. > > > Probably for future use -- for systems where the default method didn't > work, or where there was a more efficient method available. It can't be a global though. That is going to be very multi-arch / multi-target unfriendly. Mind if that gets removed as well? As it is, it is wrong. Andrew >> ------------------------------------------------------------------------ >> >> Subject: gcore for netbsd >> Date: 16 Jul 2002 03:35:47 +0200 >> From: Love >> To: gdb@sources.redhat.com >> >> Hi >> >> I've added gcore support for netbsd, the core writing support need some >> more work (like adding more stuff to the elf notes in the netbsd core file) >> >> One simple thing you can do for me is to protect the in >> gcore.c like its done in other files so its possible to include gcore.c on >> platforms that doesn't have . >> >> Love >> >> Index: gcore.c >> =================================================================== >> RCS file: /cvs/src/src/gdb/gcore.c,v >> retrieving revision 1.5 >> diff -u -u -w -r1.5 gcore.c >> --- gcore.c 12 Apr 2002 23:09:48 -0000 1.5 >> +++ gcore.c 16 Jul 2002 01:30:03 -0000 >> @@ -23,7 +23,9 @@ >> #include "inferior.h" >> #include "gdbcore.h" >> #include "elf-bfd.h" >> +#ifdef HAVE_SYS_PROCFS_H >> #include >> +#endif >> #include "symfile.h" >> #include "objfiles.h" >> > >