From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-17354-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 24815 invoked by alias); 5 Aug 2002 23:13:32 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 24807 invoked from network); 5 Aug 2002 23:13:31 -0000
Received: from unknown (HELO cygnus.com) (205.180.83.203)
  by sources.redhat.com with SMTP; 5 Aug 2002 23:13:31 -0000
Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id QAA05248;
	Mon, 5 Aug 2002 16:11:55 -0700 (PDT)
Message-ID: <3D4F023B.A6B5BD9@redhat.com>
Date: Mon, 05 Aug 2002 16:13:00 -0000
From: Michael Snyder <msnyder@redhat.com>
Organization: Red Hat, Inc.
X-Accept-Language: en
MIME-Version: 1.0
To: gdb-patches@sources.redhat.com, cagney@redhat.com
Subject: Re: [Fwd: gcore for netbsd]
References: <3D4D6C36.8050407@ges.redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-08/txt/msg00104.txt.bz2

Andrew Cagney wrote:
> 
> Hello,
> 
> This patch has made me wonder why gcore even includes <sys/procfs.h>.

I'm guessing it went in before I split some code out into linux-proc.c.


> Can anyone think of a reason for not simply removing the include?
	
Try it and see...

> I'm also wondering what the function preempt_derive_stack_segment() is
> for.  I can't find any callers.

Probably for future use -- for systems where the default method didn't 
work, or where there was a more efficient method available.


>   ------------------------------------------------------------------------
> 
> Subject: gcore for netbsd
> Date: 16 Jul 2002 03:35:47 +0200
> From: Love <lha@stacken.kth.se>
> To: gdb@sources.redhat.com
> 
> Hi
> 
> I've added gcore support for netbsd, the core writing support need some
> more work (like adding more stuff to the elf notes in the netbsd core file)
> 
> One simple thing you can do for me is to protect the <sys/procfs.h> in
> gcore.c like its done in other files so its possible to include gcore.c on
> platforms that doesn't have <sys/procfs.h>.
> 
> Love
> 
> Index: gcore.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/gcore.c,v
> retrieving revision 1.5
> diff -u -u -w -r1.5 gcore.c
> --- gcore.c     12 Apr 2002 23:09:48 -0000      1.5
> +++ gcore.c     16 Jul 2002 01:30:03 -0000
> @@ -23,7 +23,9 @@
>  #include "inferior.h"
>  #include "gdbcore.h"
>  #include "elf-bfd.h"
> +#ifdef HAVE_SYS_PROCFS_H
>  #include <sys/procfs.h>
> +#endif
>  #include "symfile.h"
>  #include "objfiles.h"
>