From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14782 invoked by alias); 1 Aug 2002 23:38:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14774 invoked from network); 1 Aug 2002 23:38:32 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 1 Aug 2002 23:38:32 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 93EC03C63; Thu, 1 Aug 2002 19:38:32 -0400 (EDT) Message-ID: <3D49C678.1020106@ges.redhat.com> Date: Thu, 01 Aug 2002 16:38:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020708 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Michael Snyder , Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] 64-bit support for Irix 6 References: <1020731172757.ZM21630@localhost.localdomain> <3D494F95.5060708@ges.redhat.com> <3D499BCF.2E79188@redhat.com> <3D49A72F.7040108@ges.redhat.com> <3D49A814.A75E2C66@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00038.txt.bz2 > If you mean mips_push_arguments, then that is already part of the >> multi-arch vector. > > > Umm... no it isn't. I can see why you think it is > (set_gdbarch_push_arguments is called), but the call to > PUSH_ARGUMENTS is still going thru the macro in tm-mips.h. I think the macro can be yanked. Not sure why it has remained. >> Just don't forget that any changes to that function >> should be multi-arch friendly. > > > So I can use code similar to what is already there > (eg. "if (tdep->mips_abi == MIPS_ABI_N32)") > rather than splitting the function into variously > mips_n32_push_argument etc.? Adding ``if (.. == MIPS_ABI_N32)'' wouldn't be multi-arch unfriendly. However, it would definitly be GDB developer/maintainer unfriendly. The MIPS is held up as an example of how to not implement the push arguments function. If the MIPS doesn't support your new ABI then I think you are way better off creating a new mips_ABI_push_arguments() function and model its implementation on the Arm. Even cloning mips_push_arguments() and then stripping out all the irrelenvant guff would be better. That way you would be sure it didn't break any of the other ABIs. enjoy, Andrew