From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25889 invoked by alias); 1 Aug 2002 21:55:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25881 invoked from network); 1 Aug 2002 21:55:53 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 1 Aug 2002 21:55:53 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 1BD4E3C63; Thu, 1 Aug 2002 17:55:54 -0400 (EDT) Message-ID: <3D49AE69.3040708@ges.redhat.com> Date: Thu, 01 Aug 2002 14:55:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020708 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner , Michael Snyder Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] mips_push_arguments(): Make O64 ABI test explicit References: <1020731210452.ZM23445@localhost.localdomain> <3D486843.8007D610@redhat.com> <1020731232203.ZM24308@localhost.localdomain> <3D4870EB.BB9C282A@redhat.com> <1020801011054.ZM24816@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00026.txt.bz2 From mips-tdep.c: /* A non-floating-point argument being passed in a general register. If a struct or union, and if the remaining length is smaller than the register size, we have to adjust the register value on big endian targets. It does not seem to be necessary to do the same for integral types. Also don't do this adjustment on EABI and O64 binaries. cagney/2001-07-23: gdb/179: Also, GCC, when outputting LE O32 with sizeof (struct) < MIPS_SAVED_REGSIZE, generates a left shift as part of storing the argument in a register a register (the left shift isn't generated when sizeof (struct) >= MIPS_SAVED_REGSIZE). Since it is quite possible that this is GCC contradicting the LE/O32 ABI, GDB has not been adjusted to accommodate this. Either someone needs to demonstrate that the LE/O32 ABI specifies such a left shift OR this new ABI gets identified as such and GDB gets tweaked accordingly. */ Sounds like the comment should be updated to mention a few more ABIs and confirm that it is GCC that is wrong. I'll assume this patch is withdrawn. enjoy, Andrew