From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-17267-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 12259 invoked by alias); 1 Aug 2002 20:48:06 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 12252 invoked from network); 1 Aug 2002 20:48:05 -0000
Received: from unknown (HELO localhost.redhat.com) (216.138.202.10)
  by sources.redhat.com with SMTP; 1 Aug 2002 20:48:05 -0000
Received: from ges.redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 171E73C63; Thu,  1 Aug 2002 16:48:06 -0400 (EDT)
Message-ID: <3D499E85.9080506@ges.redhat.com>
Date: Thu, 01 Aug 2002 13:48:00 -0000
From: Andrew Cagney <ac131313@ges.redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020708
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Joel Brobecker <brobecker@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Missing #include in objfiles.h?
References: <20020801192836.GY683@gnat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-08/txt/msg00017.txt.bz2

> I'm not sure if this is intended or not, but objfiles.h relies on
> symfile.h for the definition of certain structures. However, objfiles
> does not #include symfile. So my attempt to include objfiles without
> prior including symfile caused a compilation error. 

What exactly?  A mindless grep suggests opaque references but not a hard 
dependency.  Adding an opaque ``struct sym_fns;'' to avoid an include is ok.

> This patch adds the #include, assuming this was not intentional. Tested
> by "./configure; make".
> 
> 2002-08-01  Joel Brobecker  <brobecker@gnat.com>
> 
>         * objfiles.h: Add missing #include "symfile.h"
>         
>         * Makefile.in (objfiles_h): Add dependency on symfile.h and dependents.
> 
> Ok to apply?

If there is a direct dependency then, yes, it should include it.

> + #include "symfile.h"

Suggest a comment mentioning what was needed.

enjoy,
Andrew

PS: I've this memory of, on true64 or hpux, there being a tangled mess 
of includes that stopped the above from being added.  That, however, is 
a true64/hppa problem and is likely fixed by multi-arching.