From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-17266-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 4426 invoked by alias); 1 Aug 2002 20:28:49 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 4409 invoked from network); 1 Aug 2002 20:28:46 -0000
Received: from unknown (HELO localhost.redhat.com) (216.138.202.10)
  by sources.redhat.com with SMTP; 1 Aug 2002 20:28:46 -0000
Received: from ges.redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 61C153C63; Thu,  1 Aug 2002 16:28:47 -0400 (EDT)
Message-ID: <3D4999FF.5040504@ges.redhat.com>
Date: Thu, 01 Aug 2002 13:28:00 -0000
From: Andrew Cagney <ac131313@ges.redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020708
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] 64-bit support for Irix 6
References: <1020731172757.ZM21630@localhost.localdomain> 	<3D494F95.5060708@ges.redhat.com> 	<1020801165318.ZM27591@localhost.localdomain> 	<3D497309.7020300@ges.redhat.com> <1020801200749.ZM29220@localhost.localdomain>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-08/txt/msg00016.txt.bz2

> 
> I've committed the change below.

Where is the fire?

>    set_gdbarch_integer_to_address (gdbarch, mips_integer_to_address);
> +
> +  set_gdbarch_register_virtual_type (gdbarch, mips_register_virtual_type);
>  

Can you please add a comment here explaining that many MIPS targets do 
not yet use this method because they are still defining the macro.

As a separate patch, could you please update things so that:

> +static struct type *
> +mips_register_virtual_type (int reg)
> +{
> +  if (FP0_REGNUM <= reg && reg < FP0_REGNUM + 32)
> +    return builtin_type_double;

This returns ieee_double big/little.

> +  else if (reg == PS_REGNUM /* CR */)
> +    return builtin_type_uint32;
> +  else if (FCRCS_REGNUM <= reg && reg <= LAST_EMBED_REGNUM)
> +    return builtin_type_uint32;
> +  else
> +    {
> +      /* Everything else... return ``long long'' when registers
> +         are 64-bits wide, ``int'' otherwise.  */
> +      if (MIPS_REGSIZE == TYPE_LENGTH (builtin_type_long_long))
> +	return builtin_type_long_long;

This returns builtin_type_uint64.

> +      else

> +	return builtin_type_int;

This returns builtin_type_uint32.

Andrew