From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-17147-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 13216 invoked by alias); 29 Jul 2002 15:52:04 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 13209 invoked from network); 29 Jul 2002 15:52:02 -0000
Received: from unknown (HELO localhost.redhat.com) (66.30.197.194)
  by sources.redhat.com with SMTP; 29 Jul 2002 15:52:02 -0000
Received: from ges.redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id C88293F45; Mon, 29 Jul 2002 11:51:55 -0400 (EDT)
Message-ID: <3D45649B.2030403@ges.redhat.com>
Date: Mon, 29 Jul 2002 08:56:00 -0000
From: Andrew Cagney <ac131313@ges.redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020708
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] utils.c: Revise a couple of internal_error() messages
References: <1020727020803.ZM21102@localhost.localdomain>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-07/txt/msg00550.txt.bz2

>  {
>    if (sizeof (ptr) != TYPE_LENGTH (builtin_type_void_data_ptr))
>      internal_error (__FILE__, __LINE__,
> -		    "core_addr_to_void_ptr: bad cast");
> +		    "host_pointer_to_address: bad cast");
>    return POINTER_TO_ADDRESS (builtin_type_void_data_ptr, &ptr);
>  }

BTW, another (easier/better?) way of resolving this is to convert the 
above into gdb_assert().  That way you pick up the function name for 
free (and in a maintainable way).

enjoy,
Andrew