From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31973 invoked by alias); 15 Jul 2002 20:42:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31961 invoked from network); 15 Jul 2002 20:42:47 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 15 Jul 2002 20:42:47 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 618863C03; Mon, 15 Jul 2002 16:42:47 -0400 (EDT) Message-ID: <3D3333C7.7060300@ges.redhat.com> Date: Mon, 15 Jul 2002 15:00:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020708 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/5.2/commit] Zap __func__ References: <3D32FB89.8030403@ges.redhat.com> <20020715175206.GA19809@nevyn.them.org> <3D332BFF.6030009@ges.redhat.com> <20020715202319.GA16298@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-07/txt/msg00342.txt.bz2 > Remember this is a branch and those ``__func__''s were only printed when >> there was an internal_error() - I don't think anyone is going to notice >> :-). The correct clean fix was committed to the mainline a few hours >> earlier (I looked at back patching it but noticed too many differences). > > > - internal_error (__FILE__, __LINE__, > - "%s: unknown register rule", __func__); > + internal_error (__FILE__, __LINE__, "bad switch"); > > Is there any reason not to leave the error message as it was? It's > just a matter of "update_context: unknown register rule". Replacing a > clear internal error with "bad switch" doesn't seem like a good move. If it really is an internal error due to a messed up switch then I think the message is sufficient. However .... > (having an internal_error here is a little shady anyway, it's like > abort()ing on user input) .... it sounds like these should be replaced by error() (or complain()). If it is triggered by a bad input file then, yes, you are correct. Andrew